Add standard signal snapshots - #114
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 697c5d9d51
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| metadata={ | ||
| **signal_metadata, | ||
| "latest_price_source": signal_metadata.get("price_source_mode") | ||
| or "ibkr_strategy_market_data", |
There was a problem hiding this comment.
Refresh snapshot after execution pricing fallback
When an executed cycle later uses execute_rebalance price fallbacks, this pre-execution snapshot is the one rendered into dashboard/strategy_dashboard and then passed to render_trade_notification, and it is never refreshed after execution_summary supplies price_source_mode or snapshot_price_fallback_used. In that scenario the notification’s signal snapshot still reports ibkr_strategy_market_data with no fallback warning even though the runtime report is corrected later in main.py; update signal_metadata['signal_snapshot'] from the execution summary before publishing the trade notification.
Useful? React with 👍 / 👎.
Summary
Tests
Note: local worktree had unrelated uncommitted IBKR WIP; this PR only stages the signal snapshot files listed above.