Skip to content

Add standard signal snapshots - #114

Merged
Pigbibi merged 1 commit into
mainfrom
feature/signal-snapshot-protocol
May 27, 2026
Merged

Add standard signal snapshots#114
Pigbibi merged 1 commit into
mainfrom
feature/signal-snapshot-protocol

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add signal_snapshot.v1 payload builder
  • attach signal snapshots to IBKR notifications, runtime logs, and execution reports
  • carry execution price-source fallback information into the snapshot when available

Tests

  • .venv/bin/python -m pytest tests/test_rebalance_service.py tests/test_request_handling.py -q
  • python -m py_compile application/signal_snapshot.py application/rebalance_service.py notifications/renderers.py main.py

Note: local worktree had unrelated uncommitted IBKR WIP; this PR only stages the signal snapshot files listed above.

@Pigbibi
Pigbibi merged commit 460e503 into main May 27, 2026
1 check passed
@Pigbibi
Pigbibi deleted the feature/signal-snapshot-protocol branch May 27, 2026 20:52

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 697c5d9d51

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +589 to +592
metadata={
**signal_metadata,
"latest_price_source": signal_metadata.get("price_source_mode")
or "ibkr_strategy_market_data",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Refresh snapshot after execution pricing fallback

When an executed cycle later uses execute_rebalance price fallbacks, this pre-execution snapshot is the one rendered into dashboard/strategy_dashboard and then passed to render_trade_notification, and it is never refreshed after execution_summary supplies price_source_mode or snapshot_price_fallback_used. In that scenario the notification’s signal snapshot still reports ibkr_strategy_market_data with no fallback warning even though the runtime report is corrected later in main.py; update signal_metadata['signal_snapshot'] from the execution summary before publishing the trade notification.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant