-
Notifications
You must be signed in to change notification settings - Fork 1
Add manual Cloud Run deploy dispatch #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ name: Deploy Cloud Run | |
| on: | ||
| push: | ||
| branches: [ main ] | ||
| workflow_dispatch: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
With Useful? React with 👍 / 👎. |
||
|
|
||
| env: | ||
| GCP_PROJECT_ID: interactivebrokersquant | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding an unrestricted
workflow_dispatchlets an operator manually run this production deploy workflow from any selectable ref, while the job later builds and deploys${GITHUB_SHA}to the fixed Cloud Run project/service. In the scenario where a feature branch or tag is selected in the Run workflow UI/CLI, this bypasses the previouspush-only-on-mainconstraint and can deploy unmerged code; add a job-level guard such asgithub.ref == 'refs/heads/main'or otherwise validate the ref before checkout/deploy.Useful? React with 👍 / 👎.