-
Notifications
You must be signed in to change notification settings - Fork 1
Add GitHub Actions Cloud Run deploy path #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| FROM python:3.12-slim | ||
|
|
||
| ENV PYTHONUNBUFFERED=1 \ | ||
| PIP_NO_CACHE_DIR=1 \ | ||
| PORT=8080 | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| RUN apt-get update \ | ||
| && apt-get install -y --no-install-recommends git \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| COPY requirements.txt ./ | ||
| RUN python -m pip install --upgrade pip \ | ||
| && python -m pip install -r requirements.txt | ||
|
|
||
| COPY . . | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When Useful? React with 👍 / 👎. |
||
|
|
||
| CMD ["gunicorn", "--bind", ":8080", "--workers", "1", "--threads", "1", "--timeout", "300", "main:app"] | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the deploy+env-sync path, the later wait loop reads
spec.template.metadata.labels.commit-sha, but this deploy only passes--labels, which Cloud Run documents as servicemetadata.labelsrather than revision-templatespec.template.metadata.labels. With bothENABLE_GITHUB_CLOUD_RUN_DEPLOY=trueandENABLE_GITHUB_ENV_SYNC=true, the image deploy can succeed but the wait step never observes the SHA and times out before syncing env vars.Useful? React with 👍 / 👎.