Skip to content

Honor precheck dry-run for order execution - #109

Merged
Pigbibi merged 1 commit into
mainfrom
fix-precheck-dry-run-orders
May 26, 2026
Merged

Honor precheck dry-run for order execution#109
Pigbibi merged 1 commit into
mainfrom
fix-precheck-dry-run-orders

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • thread dry_run_only_override into broker/order execution wiring
  • make /precheck order execution use the dry-run broker adapter instead of global live runtime settings
  • add a request-handling test that exercises the composer-to-order-execution path

Tests

  • PYTHONPATH=. PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /tmp/ues-test-venv/bin/python -m pytest -q tests/test_request_handling.py::test_precheck_composer_wires_dry_run_override_to_order_execution tests/test_request_handling.py::test_handle_precheck_post_uses_dry_run_override tests/test_runtime_strategy_adapters.py
  • ruff check main.py tests/test_request_handling.py

Note

A manual u1599 /precheck before this fix used live order execution because the override stopped at the composer/reporting layer. This patch prevents that class of precheck from submitting broker orders.

@Pigbibi
Pigbibi merged commit 8009033 into main May 26, 2026
1 check passed
@Pigbibi
Pigbibi deleted the fix-precheck-dry-run-orders branch May 26, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant