Skip to content

Deploy gateway sources from GitHub archive - #60

Merged
Pigbibi merged 1 commit into
mainfrom
codex/archive-based-gateway-deploy
May 28, 2026
Merged

Deploy gateway sources from GitHub archive#60
Pigbibi merged 1 commit into
mainfrom
codex/archive-based-gateway-deploy

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • deploy source from the GitHub runner as an archive instead of running git fetch/clone on the VM
  • avoid private-repository credential prompts on gateway VMs
  • document that VMs do not need GitHub credentials for deploy
  • update workflow assertions for archive-based deploy

Verification

  • python3 -m py_compile 2fa_bot.py
  • bash tests/test_install_2fa_bot_watcher.sh
  • bash tests/test_wait_for_ib_gateway_ready.sh
  • bash tests/test_workflow_shared_config.sh
  • bash tests/test_docker_compose_ports.sh
  • git diff --check

Runtime config

  • updated IB_GATEWAY_TARGETS_JSON so u15998061 uses the ubuntu VM user

@Pigbibi
Pigbibi merged commit 93003bc into main May 28, 2026
1 check passed
@Pigbibi
Pigbibi deleted the codex/archive-based-gateway-deploy branch May 28, 2026 08:00

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8dfbbf8692

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +539 to +540
case '${DEPLOY_PATH}' in
''|'/'|'/home'|'/opt')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Normalize deploy path before deleting it

When DEPLOY_PATH is misconfigured with an equivalent form such as /opt/ or /home/, it bypasses this exact-match guard and the next line runs sudo rm -rf on that directory, deleting the VM's /opt or /home contents before recreating the deploy directory. Since this change adds the destructive removal step, normalize the path or reject slash/dot variants before allowing the delete.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant