Skip to content

Dismiss IBKR login messages during gateway startup - #59

Merged
Pigbibi merged 1 commit into
mainfrom
codex/dismiss-ibkr-login-messages
May 28, 2026
Merged

Dismiss IBKR login messages during gateway startup#59
Pigbibi merged 1 commit into
mainfrom
codex/dismiss-ibkr-login-messages

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • avoid empty GitHub add-mask commands for targets without TOTP
  • dismiss the post-login IBKR Login Messages dialog from the watcher so API readiness is not blocked
  • document the new Login Messages behavior

Verification

  • python3 -m py_compile 2fa_bot.py
  • bash tests/test_install_2fa_bot_watcher.sh
  • bash tests/test_wait_for_ib_gateway_ready.sh
  • bash tests/test_workflow_shared_config.sh
  • bash tests/test_docker_compose_ports.sh
  • git diff --check

@Pigbibi
Pigbibi merged commit b761ad4 into main May 28, 2026
1 check passed
@Pigbibi
Pigbibi deleted the codex/dismiss-ibkr-login-messages branch May 28, 2026 07:38

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e3ebfc9f96

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread 2fa_bot.py
"1",
)
SUBMISSION_RESET_SECONDS_RAW = os.environ.get("IBKR_2FA_SUBMISSION_RESET_SECONDS", "0")
DISMISS_LOGIN_MESSAGES = os.environ.get("IBKR_DISMISS_LOGIN_MESSAGES", "yes").strip().lower() not in {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Plumb the dismiss toggle into the container environment

This new opt-out is only read inside 2fa_bot.py, but it is not passed through docker-compose.yml or the GitHub-generated env file in .github/workflows/main.yml, so setting IBKR_DISMISS_LOGIN_MESSAGES=no in .env or workflow variables will never reach the watcher container. In deployments that need to inspect the IBKR Login Messages dialog manually, the newly default-on dismissal cannot actually be disabled without editing the compose/service environment.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant