Dismiss IBKR login messages during gateway startup - #59
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3ebfc9f96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "1", | ||
| ) | ||
| SUBMISSION_RESET_SECONDS_RAW = os.environ.get("IBKR_2FA_SUBMISSION_RESET_SECONDS", "0") | ||
| DISMISS_LOGIN_MESSAGES = os.environ.get("IBKR_DISMISS_LOGIN_MESSAGES", "yes").strip().lower() not in { |
There was a problem hiding this comment.
Plumb the dismiss toggle into the container environment
This new opt-out is only read inside 2fa_bot.py, but it is not passed through docker-compose.yml or the GitHub-generated env file in .github/workflows/main.yml, so setting IBKR_DISMISS_LOGIN_MESSAGES=no in .env or workflow variables will never reach the watcher container. In deployments that need to inspect the IBKR Login Messages dialog manually, the newly default-on dismissal cannot actually be disabled without editing the compose/service environment.
Useful? React with 👍 / 👎.
Summary
Verification