Support multi-target gateway deploy workflow - #58
Conversation
32646c9 to
3c28afb
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32646c981e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| twofa_autofill="$(printf '%s' "${IBKR_2FA_AUTOFILL:-}" | tr '[:upper:]' '[:lower:]')" | ||
| if [ "${twofa_autofill}" = "yes" ] || [ "${twofa_autofill}" = "true" ] || [ "${twofa_autofill}" = "1" ]; then | ||
| required_values+=(totp_secret) |
There was a problem hiding this comment.
When IBKR_2FA_AUTOFILL is omitted for a target, this condition skips adding totp_secret to the required values, but the generated .env leaves the variable empty and docker-compose.yml defaults IBKR_2FA_AUTOFILL to yes via ${IBKR_2FA_AUTOFILL:-yes}. In that default configuration, 2fa_bot.py exits if TOTP_SECRET is missing, so scheduled/push deploys can now pass validation and install a gateway whose 2FA helper immediately fails. Please either treat an empty autofill value as enabled here or explicitly default the emitted value to no for non-TOTP targets.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification