Support IBKR mobile push 2FA config - #33
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce978dedce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| TWS_ACCEPT_INCOMING: ${{ vars.IB_GATEWAY_TWS_ACCEPT_INCOMING }} | ||
| READ_ONLY_API: ${{ vars.IB_GATEWAY_READ_ONLY_API }} | ||
| TWOFA_DEVICE: ${{ vars.IB_GATEWAY_TWOFA_DEVICE }} | ||
| IBKR_2FA_AUTOFILL: ${{ vars.IB_GATEWAY_2FA_AUTOFILL }} |
There was a problem hiding this comment.
Skip TOTP secret enforcement when auto-fill is disabled
Adding IBKR_2FA_AUTOFILL here introduces a push-approval mode, but the workflow still unconditionally requires TOTP_SECRET later in Check whether deployment config is complete (require_secret_source TOTP_SECRET_SECRET_NAME ...) and again after secret resolution (resolved totp_secret is empty check). In the IBKR_2FA_AUTOFILL=no scenario, users who rely on IBKR Mobile push and have no TOTP seed will fail deployment before the container starts, so the new mode is effectively unusable unless a dummy secret is supplied.
Useful? React with 👍 / 👎.
Summary
Tests