Skip to content

Support IBKR mobile push 2FA config - #33

Merged
Pigbibi merged 1 commit into
mainfrom
codex/mobile-push-2fa-config
May 10, 2026
Merged

Support IBKR mobile push 2FA config#33
Pigbibi merged 1 commit into
mainfrom
codex/mobile-push-2fa-config

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • pass optional IBC two-factor device and TOTP auto-fill mode from GitHub vars into the gateway .env
  • expose TWOFA_DEVICE in docker-compose for IBKR Mobile push selection
  • allow the local 2FA helper to run in passive logging mode when push approval is used
  • document the new shared variables

Tests

  • python3 -m py_compile 2fa_bot.py
  • bash tests/test_install_2fa_bot_watcher.sh
  • bash tests/test_wait_for_ib_gateway_ready.sh
  • bash tests/test_workflow_shared_config.sh
  • bash tests/test_docker_compose_ports.sh

@Pigbibi
Pigbibi merged commit 3f10e38 into main May 10, 2026
1 check passed
@Pigbibi
Pigbibi deleted the codex/mobile-push-2fa-config branch May 10, 2026 17:48

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce978dedce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

TWS_ACCEPT_INCOMING: ${{ vars.IB_GATEWAY_TWS_ACCEPT_INCOMING }}
READ_ONLY_API: ${{ vars.IB_GATEWAY_READ_ONLY_API }}
TWOFA_DEVICE: ${{ vars.IB_GATEWAY_TWOFA_DEVICE }}
IBKR_2FA_AUTOFILL: ${{ vars.IB_GATEWAY_2FA_AUTOFILL }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Skip TOTP secret enforcement when auto-fill is disabled

Adding IBKR_2FA_AUTOFILL here introduces a push-approval mode, but the workflow still unconditionally requires TOTP_SECRET later in Check whether deployment config is complete (require_secret_source TOTP_SECRET_SECRET_NAME ...) and again after secret resolution (resolved totp_secret is empty check). In the IBKR_2FA_AUTOFILL=no scenario, users who rely on IBKR Mobile push and have no TOTP seed will fail deployment before the container starts, so the new mode is effectively unusable unless a dummy secret is supplied.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant