Skip to content

fix dismiss all Dependabot review requests - #112

Merged
Pigbibi merged 1 commit into
mainfrom
agent/dismiss-all-dependabot-review-requests
Jul 20, 2026
Merged

fix dismiss all Dependabot review requests#112
Pigbibi merged 1 commit into
mainfrom
agent/dismiss-all-dependabot-review-requests

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Policy

Automatically generated Pigbibi review requests are dismissed only when the request event itself was created by Dependabot. Requests made by maintainers are preserved. Major dependency updates remain open because the existing auto-merge workflow excludes semver-major updates.

What changed

  • support dependabot[bot] and app/dependabot PR authors and event actors
  • react directly to review_requested events
  • serialize per-PR cleanup runs without cancelling the matching event
  • verify the latest paginated timeline request still came from Dependabot immediately before deletion
  • keep API failures visible while treating an already-removed request as success
  • do not checkout or execute PR code

Validation

  • bash syntax check
  • git diff --check

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown

🤖 Codex PR Review

Merge allowed: 1 finding(s) reported but none are blocking

ℹ️ Other Findings

1. 🟡 [MEDIUM] Logic in .github/workflows/dependabot_review_request_cleanup.yml

The new flow decides based on the last historical review_requested actor, then immediately deletes the review request without re-checking for newer human activity. If Pigbibi is manually re-requested after latest_request_actor is computed but before the DELETE request runs, this job will remove that fresh human request as well. The previous code explicitly re-read timeline events after deletion and restored concurrent human intent; this diff removes that protection and introduces a real race that can suppress legitimate review notifications. (line 46)

Suggestion: Reintroduce a post-delete concurrency check, or perform a second timeline/current-review-request read immediately before and/or after DELETE so that a human review_requested event observed during the job causes the reviewer to be restored instead of silently dismissed.


Review by Codex PR Review bot • PR

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi force-pushed the agent/dismiss-all-dependabot-review-requests branch from 776c66c to 158c40a Compare July 20, 2026 06:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 158c40abe6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/dependabot_review_request_cleanup.yml
@Pigbibi
Pigbibi merged commit 53761ee into main Jul 20, 2026
5 checks passed
@Pigbibi
Pigbibi deleted the agent/dismiss-all-dependabot-review-requests branch July 20, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant