Fix gateway recovery epoch replacement boundary #101
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| function canonical_timestamp(value, fraction, digits) { | ||
| sub(/,/, ".", value) | ||
| if (value ~ /^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}(\.[0-9]+)?Z$/) { | ||
| sub(/Z$/, "", value) | ||
| sub(/T/, " ", value) | ||
| } else if (value !~ /^[0-9]{4}-[0-9]{2}-[0-9]{2} [0-9]{2}:[0-9]{2}:[0-9]{2}(\.[0-9]+)?$/) { | ||
| return "" | ||
| } | ||
|
|
||
| if (value ~ /\./) { | ||
| fraction = value | ||
| sub(/^.*\./, "", fraction) | ||
| sub(/\..*$/, "", value) | ||
| } else { | ||
| fraction = "" | ||
| } | ||
| digits = length(fraction) | ||
| if (digits > 9) { | ||
| fraction = substr(fraction, 1, 9) | ||
| } | ||
| while (length(fraction) < 9) { | ||
| fraction = fraction "0" | ||
| } | ||
| return value "." fraction | ||
| } | ||
|
|
||
| BEGIN { | ||
| epoch_timestamp = canonical_timestamp(epoch_started_at) | ||
| if (epoch_timestamp == "") { | ||
| exit 2 | ||
| } | ||
| } | ||
|
|
||
| { | ||
| line_timestamp = "" | ||
| if ($0 ~ /^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}(\.[0-9]+)?Z[[:space:]]/) { | ||
| line_timestamp = $1 | ||
| } else if ($0 ~ /^[0-9]{4}-[0-9]{2}-[0-9]{2} [0-9]{2}:[0-9]{2}:[0-9]{2}([.,][0-9]+)?[[:space:]]/) { | ||
| line_timestamp = $1 " " $2 | ||
| } | ||
|
|
||
| line_timestamp = canonical_timestamp(line_timestamp) | ||
| if (line_timestamp == "" || line_timestamp < epoch_timestamp) { | ||
|
There was a problem hiding this comment.
When Useful? React with 👍 / 👎. |
||
| next | ||
| } | ||
| if ($0 ~ terminal_regex) { | ||
| terminal_found = 1 | ||
| } | ||
| if ($0 ~ progress_regex) { | ||
| progress_found = 1 | ||
| } | ||
| } | ||
|
|
||
| END { | ||
| if (terminal_found) { | ||
| print "terminal" | ||
| } else if (progress_found) { | ||
| print "progress" | ||
| } else { | ||
| print "none" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| ib_gateway_started_at_is_valid() { | ||
| local started_at="${1:-}" | ||
|
|
||
| [[ "${started_at}" =~ ^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}(\.[0-9]+)?Z$ ]] \ | ||
| && [[ "${started_at}" != 0001-01-01T00:00:00* ]] | ||
| } | ||
|
|
||
| ib_gateway_inspect_container_epoch() { | ||
| local container_ref="${1:-}" | ||
| local inspect_record container_id started_at | ||
|
|
||
| [ -n "${container_ref}" ] || return 1 | ||
| inspect_record="$(docker inspect --format '{{.Id}} {{.State.StartedAt}}' "${container_ref}" 2>/dev/null)" \ | ||
| || return 1 | ||
| read -r container_id started_at <<<"${inspect_record}" | ||
| [ -n "${container_id}" ] || return 1 | ||
| ib_gateway_started_at_is_valid "${started_at}" || return 1 | ||
| printf '%s %s\n' "${container_id}" "${started_at}" | ||
| } | ||
|
|
||
| ib_gateway_validate_replacement_epoch() { | ||
| local old_container_id="${1:-}" | ||
| local replacement_container_id="${2:-}" | ||
| local replacement_started_at="${3:-}" | ||
|
|
||
| [ -n "${old_container_id}" ] \ | ||
| && [ -n "${replacement_container_id}" ] \ | ||
| && [ "${old_container_id}" != "${replacement_container_id}" ] \ | ||
| && ib_gateway_started_at_is_valid "${replacement_started_at}" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On hosts where plain
awkresolves tomawk(common on Ubuntu/Debian images), this interval regexp with an optional group aborts the classifier with aREcompile() - panicerror; becauserecover_ib_gateway_ready.shinvokesawkdirectly, replacement log classification then produces no activity instead of detecting progress or terminal events. Use a POSIX-compatible pattern or requiregawkso recovery does not silently skip the new epoch policy on those hosts.Useful? React with 👍 / 👎.