chore(deps): align QPK pin to 2dee23c125c0 - #94
Conversation
Automated downstream QPK pin update after QPK_PIN landed on main. Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Codex PR Review✅ Merge allowed: No issues found Review by Codex PR Review bot • PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5654f8abc6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| dependencies = [ | ||
| "pandas>=2.0", | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@31892425a02242126265ac07a626d98796daa459", | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@2dee23c125c0b1b60946b3bf9e48ce75991bba36", |
There was a problem hiding this comment.
Pin to QPK_PIN instead of the QPK head commit
This SHA is the QuantPlatformKit commit that updated QPK_PIN, not the canonical pin value itself. The CI workflow’s “Check QPK pin and lock consistency” step runs external/QuantPlatformKit/scripts/check_qpk_pin_consistency.py --pin-file external/QuantPlatformKit/QPK_PIN (.github/workflows/ci.yml lines 67-72), and at the referenced QPK commit QPK_PIN still contains 31892425a02242126265ac07a626d98796daa459; with this line changed to 2dee23c..., that check reports the dependency files as mismatched and fails before tests run.
Useful? React with 👍 / 👎.
|
Superseded by the newer QPK pin PR opened after the latest QuantPlatformKit manifest update. |
Summary
2dee23c125c0uv.lock,同步刷新 lockfileTest plan
🤖 Generated with Claude Code