Skip to content

chore: use org-level TG_TOKEN secret #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 4 commits into from
Jul 8, 2026
Merged

chore: use org-level TG_TOKEN secret #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d076f9a
chore: use org-level TG_TOKEN secret
Pigbibi Jul 7, 2026
86a5bc7
fix: sync QPK pin
Pigbibi Jul 8, 2026
e8d4cdf
chore: trigger CI
Pigbibi Jul 8, 2026
1b8d135
fix: update test assertion for org TG_TOKEN secret ref
Pigbibi Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/sync-cloud-run-env.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ jobs:
STRATEGY_PLUGIN_ALERT_SMS_AUTH_TOKEN: ${{ secrets.STRATEGY_PLUGIN_ALERT_SMS_AUTH_TOKEN }}
STRATEGY_PLUGIN_ALERT_PUSH_APP_TOKEN: ${{ secrets.STRATEGY_PLUGIN_ALERT_PUSH_APP_TOKEN }}
STRATEGY_PLUGIN_ALERT_PUSH_ACCESS_TOKEN: ${{ secrets.STRATEGY_PLUGIN_ALERT_PUSH_ACCESS_TOKEN }}
STRATEGY_PLUGIN_ALERT_TELEGRAM_BOT_TOKEN: ${{ secrets.STRATEGY_PLUGIN_ALERT_TELEGRAM_BOT_TOKEN }}
STRATEGY_PLUGIN_ALERT_TELEGRAM_BOT_TOKEN: ${{ secrets.TG_TOKEN }}

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the workflow test for TG_TOKEN

In the inspected CI workflow, tests still run via .github/workflows/ci.yml:94-95, and tests/test_sync_cloud_run_env_workflow.py:118-121 still asserts that this workflow contains ${{ secrets.STRATEGY_PLUGIN_ALERT_TELEGRAM_BOT_TOKEN }}. With this line changed to ${{ secrets.TG_TOKEN }}, the focused command python -m pytest tests/test_sync_cloud_run_env_workflow.py -q now fails before the later QPK pin check, so any CI run that reaches tests is blocked. Please update the workflow contract test (or keep a compatibility reference) together with the secret rename.

Useful? React with 👍 / 👎.

FIRSTRADE_USERNAME: ${{ secrets.FIRSTRADE_USERNAME }}
FIRSTRADE_PASSWORD: ${{ secrets.FIRSTRADE_PASSWORD }}
FIRSTRADE_MFA_SECRET: ${{ secrets.FIRSTRADE_MFA_SECRET }}
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ dependencies = [
"pytest",
"pytz",
"requests",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@37c81901160c5b31127a27dba1c63944933fb6bf",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@f1d2c323b2a96383acec83a07bbf1816938c4650",
"us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@17ddb86c72d44b2c7b78ba7a10d8f71b21180166",
]
license = "MIT"
Expand Down
2 changes: 1 addition & 1 deletion tests/test_sync_cloud_run_env_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def test_sync_cloud_run_env_workflow_uses_sync_plan_script():
) in workflow
assert (
"STRATEGY_PLUGIN_ALERT_TELEGRAM_BOT_TOKEN: "
"${{ secrets.STRATEGY_PLUGIN_ALERT_TELEGRAM_BOT_TOKEN }}"
"${{ secrets.TG_TOKEN }}"
) in workflow
assert (
"add_optional_secret STRATEGY_PLUGIN_ALERT_TELEGRAM_BOT_TOKEN "
Expand Down
Loading