Skip to content

chore(deps): align QPK pin to 8378e93 and add CI gate #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 3 commits into from
Jul 8, 2026
Merged

chore(deps): align QPK pin to 8378e93 and add CI gate #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
002abf4
chore(deps): align QPK pin to 8378e93 and add CI gate
Pigbibi Jul 8, 2026
c10bace
test(governance): update QPK_HEALTH_COMMIT to QPK_PIN
Pigbibi Jul 8, 2026
07dfcc9
ci: retrigger checks after gate cancellation
Pigbibi Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,13 @@ jobs:
set -euo pipefail
ruff check .

- name: Check QPK pin and lock consistency
run: |
set -euo pipefail
python external/QuantPlatformKit/scripts/check_qpk_pin_consistency.py \
--root . \
--pin-file external/QuantPlatformKit/QPK_PIN
Comment on lines +84 to +86

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update qsl.toml before enabling the pin gate

Under the QPK #202 script this step depends on, check_qpk_pin_consistency.py scans cross-file QSL pin drift. This repo's qsl.toml still pins QuantPlatformKit at 37c819... while this change moves pyproject.toml/uv.lock to 8378e939..., so enabling this step makes CI fail before tests even if the unit-test constant is fixed. Include qsl.toml in the pin update or hold off on running the expanded gate.

Useful? React with 👍 / 👎.


- name: Run unit tests
run: |
set -euo pipefail
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ description = "Shared crypto strategy catalog and implementations"
readme = "README.md"
requires-python = ">=3.11"
dependencies = [
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@0af622ac9d47f7ef93f9379f9ded314c27a344ff",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@8378e939d9324ea63a0f45c9f21ba0e2eeb1cfff",

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the QPK governance test with the new pin

Changing this dependency to 8378e939... makes the existing governance test fail: tests/test_contract_governance.py still defines QPK_HEALTH_COMMIT as 0af622ac... and test_qpk_dependency_includes_shared_health_module_release asserts that pyproject.toml matches that exact value. Since .github/workflows/ci.yml still runs python -m pytest -q tests, CI will fail on every run with this new pin until the test expectation is updated as part of the same change.

Useful? React with 👍 / 👎.

]

[tool.setuptools]
Expand Down
2 changes: 1 addition & 1 deletion tests/test_contract_governance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"binance",
"BINANCE_",
)
QPK_HEALTH_COMMIT = "0af622ac9d47f7ef93f9379f9ded314c27a344ff"
QPK_HEALTH_COMMIT = "8378e939d9324ea63a0f45c9f21ba0e2eeb1cfff"
QPK_OLD_HEALTHLESS_COMMIT = "86f03fb8e83c0d372f4e1c64cccf3e6da50b8dd4"


Expand Down
4 changes: 2 additions & 2 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading