Skip to content

fix Dependabot review request races #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Jul 20, 2026
Merged

fix Dependabot review request races #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions .github/workflows/dependabot_review_request_cleanup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,13 @@ jobs:
REVIEWER: Pigbibi
run: |
set -euo pipefail
latest_review_request_actor() {
gh api --paginate \
"repos/${GITHUB_REPOSITORY}/issues/${PR_NUMBER}/timeline?per_page=100" |
jq -sr --arg reviewer "${REVIEWER}" \
'[.[][] | select(.event == "review_requested" and .requested_reviewer.login == $reviewer)][-1].actor.login // ""'
}

review_requests="$(gh pr view "${PR_NUMBER}" \
--repo "${GITHUB_REPOSITORY}" \
--json reviewRequests \
Expand All @@ -39,9 +46,7 @@ jobs:
exit 0
fi

latest_request_actor="$(gh api \
"repos/${GITHUB_REPOSITORY}/issues/${PR_NUMBER}/timeline?per_page=100" \
--jq '[.[] | select(.event == "review_requested" and .requested_reviewer.login == "Pigbibi")][-1].actor.login // ""')"
latest_request_actor="$(latest_review_request_actor)"
case "${latest_request_actor}" in
'dependabot[bot]'|'app/dependabot') ;;
*)
Expand All @@ -53,4 +58,16 @@ jobs:
gh api --method DELETE \
"repos/${GITHUB_REPOSITORY}/pulls/${PR_NUMBER}/requested_reviewers" \
-f "reviewers[]=${REVIEWER}"
echo "Dismissed Dependabot review request for ${REVIEWER}." >> "${GITHUB_STEP_SUMMARY}"

latest_request_actor="$(latest_review_request_actor)"
case "${latest_request_actor}" in
'dependabot[bot]'|'app/dependabot')
echo "Dismissed Dependabot review request for ${REVIEWER}." >> "${GITHUB_STEP_SUMMARY}"
;;
*)
gh api --method POST \
"repos/${GITHUB_REPOSITORY}/pulls/${PR_NUMBER}/requested_reviewers" \
-f "reviewers[]=${REVIEWER}"
Comment on lines +68 to +70

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Respect a later removal of the review request

If a maintainer removes the bot's request, requests Pigbibi, and then retracts that request while this job is running, latest_review_request_actor still returns the maintainer because it ignores the subsequent review_request_removed timeline event. This POST then recreates a review request the maintainer explicitly removed; check the current request state or account for the later removal event before restoring.

Useful? React with 👍 / 👎.

echo "Restored review request made by ${latest_request_actor:-<unknown>}." >> "${GITHUB_STEP_SUMMARY}"
;;
esac
Loading