chore(quantecon): sync main with upstream@1.9.1#38
Merged
Conversation
* Await connection end for jupyter kernel * Add changeset for myst-execute patch Add a changeset for patching myst-execute with a note on awaiting connection end for the Jupyter kernel.
Reflects the mystmd@1.9.1 release pulled in via the upstream/main merge. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Syncs QuantEcon’s fork with jupyter-book/mystmd upstream release v1.9.1, updating version metadata across packages and incorporating the upstream patch that awaits Jupyter kernel shutdown completion.
Changes:
- Bump package versions and internal dependency ranges to
1.9.1(andmyst-executeto0.3.5) plus corresponding changelog entries. - Update kernel execution cleanup to
awaitJupyter session shutdown. - Document
logo_darksite option and fix a spelling typo in developer docs.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| quantecon/VERSION.yml | Updates upstream_base to 1.9.1 to match the synced upstream release. |
| packages/mystmd/package.json | Bumps mystmd to 1.9.1 and updates dependency on myst-cli. |
| packages/mystmd/CHANGELOG.md | Adds 1.9.1 changelog entry. |
| packages/myst-migrate/package.json | Bumps myst-migrate to 1.9.1. |
| packages/myst-migrate/CHANGELOG.md | Adds 1.9.1 heading. |
| packages/myst-execute/src/transform.ts | Awaits Jupyter session shutdown during kernel execution teardown. |
| packages/myst-execute/package.json | Bumps myst-execute to 0.3.5. |
| packages/myst-execute/CHANGELOG.md | Adds 0.3.5 changelog entry. |
| packages/myst-cli/package.json | Bumps myst-cli to 1.9.1 and updates deps on myst-migrate / myst-execute. |
| packages/myst-cli/CHANGELOG.md | Adds 1.9.1 changelog entry. |
| docs/website-templates.md | Documents logo_dark in site.options. |
| docs/developer.md | Fixes typo (“intentionally”). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
167
to
171
| } finally { | ||
| // Ensure that we shut-down the kernel | ||
| if (!sessionConnection.isDisposed) { | ||
| sessionConnection.shutdown(); | ||
| await sessionConnection.shutdown(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pulls in 5 commits from
jupyter-book/mystmd:main, including the mystmd@1.9.1 release, and bumpsquantecon/VERSION.ymlupstream_base: 1.9.0 → 1.9.1to match.Upstream commits pulled in
0d626b19🚀 v1.9.1 (🚀 Release jupyter-book/mystmd#2859)78208524✊ Bump mystmd to release (✊ Bump mystmd to release jupyter-book/mystmd#2858)ae0ad097🚀 Release (🚀 Release jupyter-book/mystmd#2854)e8402e2aDocument dark mode logo (Document dark mode logo jupyter-book/mystmd#2856)72172ff5Await connection end for jupyter kernel (Await connection end for jupyter kernel jupyter-book/mystmd#2853)Merge was clean (auto-resolution on
packages/myst-cli/package.jsononly — no conflicts).This PR contains a real merge commit (
483967e9) preservingupstream/mainancestry. Perquantecon/README.md§"Sync main with upstream" and the warning commit 8522235:Squash-merging here would rewrite the upstream commits to a new SHA, break the ancestry, and stick the "N behind" counter — every future sync would emit a near-empty merge commit until reconciled.
Test plan
git merge upstream/mainon a fresh branch produced no conflictsquantecon/VERSION.ymlupstream_basematches upstream'spackages/mystmd/package.jsonversion (1.9.1)git fetch upstream && git merge-base --is-ancestor upstream/main origin/mainexits 0 (ancestry preserved — i.e. the merge strategy was correct)🤖 Generated with Claude Code