Skip to content

[BLOG] Nasa rose grant - #428

Open
mattip wants to merge 7 commits into
mainfrom
nasa-rose-grant
Open

[BLOG] Nasa rose grant#428
mattip wants to merge 7 commits into
mainfrom
nasa-rose-grant

Conversation

@mattip

@mattip mattip commented Aug 29, 2022

Copy link
Copy Markdown
Contributor

Text styling

  • The blog is written with plain language (where relevant).
  • If there are headers, they use the proper header tags in order to do so (with only one level-one header).
  • All links describe where they link to (for example, check the Quansight labs website).
  • Any kind of styling that the author uses (for example, bold for emphasis) is consistent throughout the blog.

Non-text contents

  • All content is represented as text (for example, images need alt text and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing gifs or videos.
  • If it were to be read as plain text, the blog still makes sense and no information is missing.

@mattip
mattip requested a review from kherma as a code owner August 29, 2022 10:48
@vercel

vercel Bot commented Aug 29, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
consulting Ready Ready Preview Feb 3, 2026 10:45am
labs Ready Ready Preview, Comment Feb 3, 2026 10:45am

Request Review

@mattip

mattip commented Aug 29, 2022

Copy link
Copy Markdown
Contributor Author

xref @rgommers

here is the preview. Previous review comments:

  • Integrating the images would be useful.
  • Another thing I can work on is adding more names of people involved and who does what - I think that is needed, and will make the story more engaging as well.

Comment thread apps/labs/posts/nasa-roses-grant-2020.md Outdated
Comment thread apps/labs/posts/nasa-roses-grant-2020.md Outdated
mattip and others added 4 commits August 31, 2022 04:04
Co-authored-by: Noa Tamir <6564007+noatamir@users.noreply.github.com>
Co-authored-by: Noa Tamir <6564007+noatamir@users.noreply.github.com>
@rgommers

Copy link
Copy Markdown
Member

Now we're getting somewhere. @mattip please let me know once you have pushed this as far as you can and want me to add some detail.

@mattip

mattip commented Aug 31, 2022

Copy link
Copy Markdown
Contributor Author

@rgommers go for it

@noatamir

noatamir commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

I would suggest using new images, or if you have the source to save it at a higher resolution for the hero, and recrop it for the feature image. My concerns are:

  • The hero image appear pixelized on desktop
  • On mobile view the feature image (on the /blog page) is the wrong size, and it doesn't look good.

Desktop hero image

cropped feature image

@noatamir

noatamir commented Dec 6, 2022

Copy link
Copy Markdown
Contributor

@mattip @rgommers can I help move this forward? I can create new graphics for you?

@rgommers

rgommers commented Dec 6, 2022

Copy link
Copy Markdown
Member

@noatamir thanks for asking. This is blocked on my attention right now, I plan on circling back to this in January (I have a reminder in my calendar for it). No time before then. If you have time this month and can take care of having the required graphics in good shape, that would be helpful I think.

@lysnikolaou
lysnikolaou changed the base branch from develop to main February 2, 2026 15:17
@rgommers

rgommers commented Feb 2, 2026

Copy link
Copy Markdown
Member

@lysnikolaou thanks for the update. Now that we're going through this whole repo at lightning speed I'm inclined to get this in (unless @mattip disagrees) as a historical document. Note though that we didn't actually publish this 3 years ago.

@mattip

mattip commented Feb 2, 2026

Copy link
Copy Markdown
Contributor Author

No objections from me

@lysnikolaou

Copy link
Copy Markdown
Collaborator

@rgommers Noted. I've fixed the build issues, so this is ready to go if it's okay content-wise.

@lysnikolaou

Copy link
Copy Markdown
Collaborator

@rgommers Ping on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants