Support use of subresource alias attrib in substitutions

[jimbr70]

Various and numerous changes. This is the running produciton code for SVL.

---

This change is 

[jimbr70]

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 34 at r1 (raw file):

Previously, ayeleta wrote…

Save the lists outside of the class and not in the init

don't understand

---

Comments from Reviewable

[jimbr70]

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 243 at r1 (raw file):

Previously, ayeleta wrote…

Don't remove the old code - This needs to stay for backward compatibility with shell 1st gen older versions

? the code is there. don't understand

---

Comments from Reviewable

[jimbr70]

sandbox_scripts/helpers/Networking/NetworkingSaveNRestore.py, line 114 at r1 (raw file):

Previously, ayeleta wrote…

Call resource.execute_command instead

Done. But in testing, failed, reverted to orig code. failed to run for svl290-gg07-c3850-2 ex: 'ResourceBase' object has no attribute 'ExecuteCommand'

---

Comments from Reviewable

[jimbr70]

sandbox_scripts/helpers/Networking/NetworkingSaveNRestore.py, line 216 at r1 (raw file):

Previously, ayeleta wrote…

if version != ''

Done. tried that - fails. There's some other character or something in there. Reverted.

---

Comments from Reviewable

[jimbr70]

sandbox_scripts/helpers/Networking/NetworkingSaveNRestore.py, line 181 at r1 (raw file):

Previously, ayeleta wrote…

_get_concrete_config_file _path should return the path in case of a snapshot as well

Done.

---

Comments from Reviewable

[jimbr70]

sandbox_scripts/helpers/Networking/NetworkingSaveNRestore.py, line 223 at r1 (raw file):

Previously, jimbr70 wrote…

it is redundant wit the sandbox.report message. I favored realtime in-process messages versus saving them up. Something we can all discuss a final direction.
Leaving as is.

Done.

---

Comments from Reviewable

[jimbr70]

sandbox_scripts/helpers/Networking/NetworkingSaveNRestore.py, line 372 at r1 (raw file):

Previously, ayeleta wrote…

No need for the replace. there is a replace statement right after

Done.

---

Comments from Reviewable

[jimbr70]

sandbox_scripts/environment/teardown/teardown_resources.py, line 27 at r1 (raw file):

Previously, ayeleta wrote…

Remove from here. The ignore_models list is already initiated outside the try

Done.

---

Comments from Reviewable

[jimbr70]

sandbox_scripts/helpers/Networking/NetworkingSaveNRestore.py, line 147 at r1 (raw file):

Previously, jimbr70 wrote…

See email to Costya & Gal - was discussed. Don't remember details - hopefully they will reply

This will have to be a TODO item due to account engagement timing

---

Comments from Reviewable

[jimbr70]

sandbox_scripts/helpers/Networking/NetworkingSaveNRestore.py, line 216 at r1 (raw file):

Previously, jimbr70 wrote…

Done. tried that - fails. There's some other character or something in there. Reverted.

Well, turns out the if was on the wrong variable! Fixed test and message. Nice this was caught.

---

Comments from Reviewable

[jimbr70]

sandbox_scripts/helpers/Networking/NetworkingSaveNRestore.py, line 114 at r1 (raw file):

Previously, jimbr70 wrote…

Done. But in testing, failed, reverted to orig code. failed to run for svl290-gg07-c3850-2 ex: 'ResourceBase' object has no attribute 'ExecuteCommand'

inserted todo for follow up later

---

Comments from Reviewable

[jimbr70]

sandbox_scripts/helpers/Networking/NetworkingSaveNRestore.py, line 147 at r1 (raw file):

Previously, jimbr70 wrote…

This will have to be a TODO item due to account engagement timing

will note as todo this has to be high pri change later

---

Comments from Reviewable

[jimbr70]

sandbox_scripts/helpers/Networking/NetworkingSaveNRestore.py, line 282 at r1 (raw file):

Previously, jimbr70 wrote…

So this is not something to do with the little time remaining on the account, but I understand your idea. How do we capture this for the 'next roll'? Insert a Todo?

added todo

---

Comments from Reviewable

[jimbr70]

sandbox_scripts/helpers/Networking/NetworkingSaveNRestore.py, line 442 at r1 (raw file):

Previously, jimbr70 wrote…

not sure I agree - user may want to access/copy them for whatever... why not?

commented out

---

Comments from Reviewable

[jimbr70]

sandbox_scripts/helpers/Networking/NetworkingSaveNRestore.py, line 392 at r1 (raw file):

Previously, jimbr70 wrote…

Same comment as previous - discussions lab months ago decided to use save/restore. sorry don't recalll all the details.

we added a TODO for this

---

Comments from Reviewable

[jimbr70]

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 34 at r1 (raw file):

Previously, jimbr70 wrote…

don't understand

Done.

---

Comments from Reviewable

[coveralls]

Coverage decreased (-0.9%) to 28.907% when pulling b05cec3 on Support-use-of-subresource-alias/attrib-in-substitutions into e499f30 on develop.

[coveralls]

Coverage decreased (-0.9%) to 28.907% when pulling c35525a on Support-use-of-subresource-alias/attrib-in-substitutions into e499f30 on develop.

[coveralls]

Coverage decreased (-0.9%) to 28.907% when pulling 1f2dfa1 on Support-use-of-subresource-alias/attrib-in-substitutions into e499f30 on develop.