Skip to content

release: fix bundled channel smoke self-resolution#129

Merged
linfangw merged 2 commits into
mainfrom
linfangw-release-channel-smoke-2026-04-21
Apr 21, 2026
Merged

release: fix bundled channel smoke self-resolution#129
linfangw merged 2 commits into
mainfrom
linfangw-release-channel-smoke-2026-04-21

Conversation

@linfangw

Copy link
Copy Markdown
Member

Summary

  • fix prepack bundled-channel smoke when built extension entries import @qverisai/qverisbot/plugin-sdk/*
  • create a temporary package self-reference under node_modules/@qverisai/qverisbot during smoke so repo-root dist imports resolve like an installed package
  • add a regression test for the rewritten bundled entry import path

Verification

  • node scripts/run-vitest.mjs run test/scripts/test-built-bundled-channel-entry-smoke.test.ts
  • node scripts/test-built-bundled-channel-entry-smoke.mjs
  • commit hook pnpm check

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the smoke test script for bundled channel entries to be more modular and includes a new test suite. Key changes include the introduction of createBundledChannelSmokeInstallView to handle package self-referencing via symlinks and the export of core functions for unit testing. Review feedback suggests using a more compatible alternative to toReversed() for older Node.js environments and improving the robustness of resource tracking to ensure proper cleanup if errors occur during setup.

Comment thread scripts/test-built-bundled-channel-entry-smoke.mjs Outdated
Comment thread scripts/test-built-bundled-channel-entry-smoke.mjs Outdated
@linfangw
linfangw merged commit 114bab1 into main Apr 21, 2026
2 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant