release: fix bundled channel smoke self-resolution#129
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the smoke test script for bundled channel entries to be more modular and includes a new test suite. Key changes include the introduction of createBundledChannelSmokeInstallView to handle package self-referencing via symlinks and the export of core functions for unit testing. Review feedback suggests using a more compatible alternative to toReversed() for older Node.js environments and improving the robustness of resource tracking to ensure proper cleanup if errors occur during setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@qverisai/qverisbot/plugin-sdk/*node_modules/@qverisai/qverisbotduring smoke so repo-root dist imports resolve like an installed packageVerification
node scripts/run-vitest.mjs run test/scripts/test-built-bundled-channel-entry-smoke.test.tsnode scripts/test-built-bundled-channel-entry-smoke.mjspnpm check