release: fix bundled runtime packaging follow-ups#128
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a utility to recursively prune .bin directories from node_modules during the staging of plugin runtime dependencies, along with updated tests to verify this behavior. A review comment identifies a performance optimization in the directory traversal logic, recommending the use of pop() instead of shift() to achieve O(1) complexity and the removal of a redundant null check.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postinstalleagerly reinstalled all bundled plugin runtime deps into the package root, and staged plugin runtime deps could still include symlinked.binshims thatpackage-dist-inventoryrejects.npm install -gduring release smoke could balloon the install tree until timeout/SIGTERM, andprepackcould fail on unsafe staged paths likedist/extensions/diffs/node_modules/.bin/playwright-core.node_modules/.binshim directories before packaging.Verification
node scripts/run-vitest.mjs run test/scripts/postinstall-bundled-plugins.test.ts src/commands/doctor-bundled-plugin-runtime-deps.test.tsnode scripts/run-vitest.mjs run test/scripts/stage-bundled-plugin-runtime-deps.test.tspnpm check