release: fix prepack inventory and smoke host mapping#127
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the A2UI asset copying script to improve safety and reliability by implementing a recursive copy that skips symbolic links and ensures a clean destination directory. Additionally, the Docker installation script was updated to inject host mappings for non-local aliases regardless of the host operating system. Review feedback suggests optimizing the copying logic by removing redundant directory creation calls and deferring relative path calculations until they are specifically required for symbolic link warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm publishprepack could fail on unsafedist/canvas-host/a2ui/*entries when test-created symlinks leaked into prepared artifacts, and install smoke update lanes could fail to resolvehost.docker.internalin Docker.Verification
bash -n scripts/test-install-sh-docker.shnode scripts/run-vitest.mjs run src/scripts/canvas-a2ui-copy.test.ts test/scripts/test-install-sh-docker.test.tspnpm check