Skip to content

fix(release): tolerate missing baseline package versions #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linfangw merged 1 commit into from
Apr 20, 2026
Merged

fix(release): tolerate missing baseline package versions #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 83 additions & 27 deletions scripts/test-install-sh-docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,8 @@ SKIP_SMOKE_IMAGE_BUILD="${OPENCLAW_INSTALL_SMOKE_SKIP_IMAGE_BUILD:-0}"
SKIP_NONROOT_IMAGE_BUILD="${OPENCLAW_INSTALL_NONROOT_SKIP_IMAGE_BUILD:-0}"
SKIP_UPDATE="${OPENCLAW_INSTALL_SMOKE_SKIP_UPDATE:-0}"
SKIP_NPM_GLOBAL="${OPENCLAW_INSTALL_SMOKE_SKIP_NPM_GLOBAL:-0}"
UPDATE_BASELINE_VERSION="${OPENCLAW_INSTALL_SMOKE_UPDATE_BASELINE:-2026.4.10}"
REQUESTED_UPDATE_BASELINE_VERSION="${OPENCLAW_INSTALL_SMOKE_UPDATE_BASELINE:-2026.4.10}"
UPDATE_BASELINE_VERSION="$REQUESTED_UPDATE_BASELINE_VERSION"
UPDATE_PACKAGE_SPEC="${OPENCLAW_INSTALL_SMOKE_UPDATE_PACKAGE_SPEC:-}"
UPDATE_DIST_IMAGE="${OPENCLAW_INSTALL_SMOKE_UPDATE_DIST_IMAGE:-}"
UPDATE_SKIP_LOCAL_BUILD="${OPENCLAW_INSTALL_SMOKE_UPDATE_SKIP_LOCAL_BUILD:-0}"
Expand All @@ -166,6 +167,40 @@ BASELINE_TAG_URL=""
FRESH_TAG_URL=""
UPDATE_TAG_URL=""
UPDATE_DOCKER_HOST_ARGS=()
UPDATE_SKIP_REASON=""

resolve_update_baseline_version() {
local versions_json
versions_json="$(quiet_npm view "$PACKAGE_NAME" versions --json 2>/dev/null || true)"

@gemini-code-assist gemini-code-assist Bot Apr 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Passing the output of npm view directly as a command-line argument to node -e can be risky if the package has a very large number of versions, as it might exceed the maximum command-line length limit (ARG_MAX). A safer approach would be to pipe the JSON string to stdin and read it within the Node.js script.

node -e '
const requested = String(process.argv[1] || "");
const expected = String(process.argv[2] || "");
const raw = String(process.argv[3] || "");
let versions;
try {
versions = JSON.parse(raw);
} catch {
versions = raw ? [raw] : [];
}
if (!Array.isArray(versions)) {
versions = versions ? [versions] : [];
}
versions = versions
.map((value) => String(value ?? "").trim())
.filter((value) => value.length > 0);
if (versions.length === 0) {
process.exit(0);
}
if (requested && versions.includes(requested)) {
process.stdout.write(requested);
process.exit(0);
}
const fallback = [...versions].reverse().find((value) => value !== expected) ?? "";

@gemini-code-assist gemini-code-assist Bot Apr 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The fallback logic currently picks the most recently published version that is not the expected version. While this is generally correct, it doesn't guarantee that the fallback is older than the current version. If a newer version was published from another branch, the update smoke test would effectively be testing a downgrade. Consider filtering for versions that are semantically older than the expected version if the intent is strictly an upgrade test.

if (fallback) {
process.stdout.write(fallback);
}
' "$REQUESTED_UPDATE_BASELINE_VERSION" "$UPDATE_EXPECT_VERSION" "$versions_json"
}

cleanup() {
if [[ -n "$UPDATE_SERVER_PID" ]]; then
Expand Down Expand Up @@ -261,6 +296,17 @@ process.stdout.write(last.version);
exit 1
fi

UPDATE_BASELINE_VERSION="$(resolve_update_baseline_version)"
if [[ -z "$UPDATE_BASELINE_VERSION" ]]; then
UPDATE_SKIP_REASON="no published baseline version is available for ${PACKAGE_NAME}"
echo "==> Skip update baseline: $UPDATE_SKIP_REASON"
return 0
fi

if [[ "$UPDATE_BASELINE_VERSION" != "$REQUESTED_UPDATE_BASELINE_VERSION" ]]; then
echo "==> Fallback baseline version: requested ${PACKAGE_NAME}@${REQUESTED_UPDATE_BASELINE_VERSION}, using ${PACKAGE_NAME}@${UPDATE_BASELINE_VERSION}"
fi

echo "==> Pack baseline tgz: ${PACKAGE_NAME}@${UPDATE_BASELINE_VERSION}"
quiet_npm pack "${PACKAGE_NAME}@${UPDATE_BASELINE_VERSION}" --json --pack-destination "$UPDATE_DIR" >"$baseline_pack_json_file"
BASELINE_TGZ_FILE="$(
Expand Down Expand Up @@ -291,10 +337,16 @@ start_update_server() {
if [[ -z "$UPDATE_PORT" ]]; then
UPDATE_PORT="$(allocate_host_port)"
fi
BASELINE_TAG_URL="http://${UPDATE_HOST_ALIAS}:${UPDATE_PORT}/${BASELINE_TGZ_FILE}"
if [[ -n "$BASELINE_TGZ_FILE" ]]; then
BASELINE_TAG_URL="http://${UPDATE_HOST_ALIAS}:${UPDATE_PORT}/${BASELINE_TGZ_FILE}"
else
BASELINE_TAG_URL=""
fi
FRESH_TAG_URL="http://${UPDATE_HOST_ALIAS}:${UPDATE_PORT}/${UPDATE_TGZ_FILE}"
UPDATE_TAG_URL="http://${UPDATE_HOST_ALIAS}:${UPDATE_PORT}/${UPDATE_TGZ_FILE}"
echo "==> Serve baseline tgz: $BASELINE_TAG_URL"
if [[ -n "$BASELINE_TAG_URL" ]]; then
echo "==> Serve baseline tgz: $BASELINE_TAG_URL"
fi
echo "==> Serve latest tgz: $FRESH_TAG_URL"
(
cd "$UPDATE_DIR"
Expand Down Expand Up @@ -351,36 +403,16 @@ else
LATEST_VERSION="$(cat "$LATEST_FILE")"
fi

echo "==> Run update smoke (${UPDATE_BASELINE_VERSION} -> ${UPDATE_EXPECT_VERSION})"
docker run --rm -t \
--platform "$SMOKE_PLATFORM" \
"${UPDATE_DOCKER_HOST_ARGS[@]}" \
-e QVERISBOT_INSTALL_PACKAGE="$PACKAGE_NAME" \
-e OPENCLAW_INSTALL_PACKAGE="$PACKAGE_NAME" \
-e OPENCLAW_INSTALL_SMOKE_MODE=update \
-e QVERISBOT_INSTALL_UPDATE_BASELINE="$UPDATE_BASELINE_VERSION" \
-e OPENCLAW_INSTALL_UPDATE_BASELINE="$UPDATE_BASELINE_VERSION" \
-e QVERISBOT_INSTALL_UPDATE_BASELINE_TAG_URL="$BASELINE_TAG_URL" \
-e OPENCLAW_INSTALL_UPDATE_BASELINE_TAG_URL="$BASELINE_TAG_URL" \
-e QVERISBOT_INSTALL_UPDATE_EXPECT_VERSION="$UPDATE_EXPECT_VERSION" \
-e OPENCLAW_INSTALL_UPDATE_EXPECT_VERSION="$UPDATE_EXPECT_VERSION" \
-e QVERISBOT_INSTALL_UPDATE_TAG_URL="$UPDATE_TAG_URL" \
-e OPENCLAW_INSTALL_UPDATE_TAG_URL="$UPDATE_TAG_URL" \
-e OPENCLAW_NO_ONBOARD=1 \
-e OPENCLAW_NO_PROMPT=1 \
-e DEBIAN_FRONTEND=noninteractive \
"$SMOKE_IMAGE"

if [[ "$SKIP_NPM_GLOBAL" == "1" ]]; then
echo "==> Skip direct npm global smoke (OPENCLAW_INSTALL_SMOKE_SKIP_NPM_GLOBAL=1)"
if [[ -z "$BASELINE_TGZ_FILE" ]]; then
echo "==> Skip update smoke (${UPDATE_SKIP_REASON})"
else
echo "==> Run direct npm global smoke (${UPDATE_BASELINE_VERSION} -> ${UPDATE_EXPECT_VERSION})"
echo "==> Run update smoke (${UPDATE_BASELINE_VERSION} -> ${UPDATE_EXPECT_VERSION})"
docker run --rm -t \
--platform "$SMOKE_PLATFORM" \
"${UPDATE_DOCKER_HOST_ARGS[@]}" \
-e QVERISBOT_INSTALL_PACKAGE="$PACKAGE_NAME" \
-e OPENCLAW_INSTALL_PACKAGE="$PACKAGE_NAME" \
-e OPENCLAW_INSTALL_SMOKE_MODE=npm-global \
-e OPENCLAW_INSTALL_SMOKE_MODE=update \
-e QVERISBOT_INSTALL_UPDATE_BASELINE="$UPDATE_BASELINE_VERSION" \
-e OPENCLAW_INSTALL_UPDATE_BASELINE="$UPDATE_BASELINE_VERSION" \
-e QVERISBOT_INSTALL_UPDATE_BASELINE_TAG_URL="$BASELINE_TAG_URL" \
Expand All @@ -393,6 +425,30 @@ else
-e OPENCLAW_NO_PROMPT=1 \
-e DEBIAN_FRONTEND=noninteractive \
"$SMOKE_IMAGE"

if [[ "$SKIP_NPM_GLOBAL" == "1" ]]; then
echo "==> Skip direct npm global smoke (OPENCLAW_INSTALL_SMOKE_SKIP_NPM_GLOBAL=1)"
else
echo "==> Run direct npm global smoke (${UPDATE_BASELINE_VERSION} -> ${UPDATE_EXPECT_VERSION})"
docker run --rm -t \
--platform "$SMOKE_PLATFORM" \
"${UPDATE_DOCKER_HOST_ARGS[@]}" \
-e QVERISBOT_INSTALL_PACKAGE="$PACKAGE_NAME" \
-e OPENCLAW_INSTALL_PACKAGE="$PACKAGE_NAME" \
-e OPENCLAW_INSTALL_SMOKE_MODE=npm-global \
-e QVERISBOT_INSTALL_UPDATE_BASELINE="$UPDATE_BASELINE_VERSION" \
-e OPENCLAW_INSTALL_UPDATE_BASELINE="$UPDATE_BASELINE_VERSION" \
-e QVERISBOT_INSTALL_UPDATE_BASELINE_TAG_URL="$BASELINE_TAG_URL" \
-e OPENCLAW_INSTALL_UPDATE_BASELINE_TAG_URL="$BASELINE_TAG_URL" \
-e QVERISBOT_INSTALL_UPDATE_EXPECT_VERSION="$UPDATE_EXPECT_VERSION" \
-e OPENCLAW_INSTALL_UPDATE_EXPECT_VERSION="$UPDATE_EXPECT_VERSION" \
-e QVERISBOT_INSTALL_UPDATE_TAG_URL="$UPDATE_TAG_URL" \
-e OPENCLAW_INSTALL_UPDATE_TAG_URL="$UPDATE_TAG_URL" \
-e OPENCLAW_NO_ONBOARD=1 \
-e OPENCLAW_NO_PROMPT=1 \
-e DEBIAN_FRONTEND=noninteractive \
"$SMOKE_IMAGE"
fi
fi
fi

Expand Down
24 changes: 24 additions & 0 deletions test/scripts/test-install-sh-docker.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,30 @@ describe("test-install-sh-docker", () => {
expect(script).toContain('from "./scripts/lib/npm-pack-budget.mjs"');
expect(script).toContain("install smoke cannot verify pack budget");
});

it("falls back to another published baseline version when the requested one is unavailable", () => {
const script = readFileSync(SCRIPT_PATH, "utf8");

expect(script).toContain("resolve_update_baseline_version");
expect(script).toContain(
'REQUESTED_UPDATE_BASELINE_VERSION="${OPENCLAW_INSTALL_SMOKE_UPDATE_BASELINE:-2026.4.10}"',
);
expect(script).toContain(
'if [[ "$UPDATE_BASELINE_VERSION" != "$REQUESTED_UPDATE_BASELINE_VERSION" ]]; then',
);
expect(script).toContain("Fallback baseline version: requested");
});

it("skips only the update lanes when no published baseline version exists", () => {
const script = readFileSync(SCRIPT_PATH, "utf8");

expect(script).toContain(
'UPDATE_SKIP_REASON="no published baseline version is available for ${PACKAGE_NAME}"',
);
expect(script).toContain('if [[ -z "$BASELINE_TGZ_FILE" ]]; then');
expect(script).toContain('echo "==> Skip update smoke (${UPDATE_SKIP_REASON})"');
expect(script).toContain('if [[ -n "$BASELINE_TAG_URL" ]]; then');
});
});

describe("install-sh smoke runner", () => {
Expand Down
Loading