Skip to content

V2026.4.3#118

Merged
linfangw merged 2 commits into
mainfrom
v2026.4.3
Apr 3, 2026
Merged

V2026.4.3#118
linfangw merged 2 commits into
mainfrom
v2026.4.3

Conversation

@linfangw

@linfangw linfangw commented Apr 3, 2026

Copy link
Copy Markdown
Member

No description provided.

@linfangw
linfangw merged commit ad7829f into main Apr 3, 2026
2 of 9 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a bulk version update across numerous extensions to 2026.4.3 and synchronizes their respective changelogs. Additionally, it updates the generated channel configuration metadata to include new properties such as 'contextVisibility', 'execApprovals', and 'ingest'. A technical concern was raised regarding the 'execApprovals' schema, suggesting that identifiers should be restricted to strings to avoid precision loss associated with 64-bit integers in JavaScript.

Comment on lines +6801 to +6810
items: {
anyOf: [
{
type: "string",
},
{
type: "number",
},
],
},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using number for user or channel identifiers in a JSON schema can lead to precision loss in JavaScript/TypeScript when dealing with 64-bit integers (such as IDs from Discord or Telegram). It is safer to use string for all ID-like fields to ensure they are handled correctly regardless of their magnitude.

              items: {
                type: "string",
              },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant