Dev

[llLeo306]

Summary by Sourcery

Bug Fixes:

• Fix the sign of the remote control yaw channel scaling so gimbal yaw responds in the expected direction.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the VT13 gimbal yaw output mapping by flipping the sign of the right-stick X channel contribution while keeping pitch mapping unchanged.

Flow diagram for updated VT13 gimbal yaw mapping

flowchart TD
  A[Read curr_rc.ch_r_x] --> B[Convert ch_r_x to float]
  B --> C[Subtract VT13_CH_VALUE_MID]
  C --> D[Multiply by 2.0f]
  D --> E[Multiply by INV_FULL_RANGE]
  E --> F[Assign to output_data.gimbal.yaw]

Loading

File-Level Changes

Change	Details	Files
Modify gimbal yaw computation by inverting the sign of the right-stick X axis scaling factor while leaving pitch computation as-is.	Change yaw output computation factor from -2.0f to 2.0f for the right-stick X channel Keep pitch output computation using 2.0f scaling for the right-stick Y channel unchanged	VT13.hpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Since this change flips the sign of the yaw command, verify that it remains consistent with other axis conventions (e.g., pitch and roll) and with any assumptions in consumers of output_data.gimbal.yaw to avoid unintuitive control behavior.
• If this sign flip is intentional to match a specific hardware or user-control convention, consider adding a brief inline comment explaining the rationale so future maintainers understand why yaw uses this direction.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Since this change flips the sign of the yaw command, verify that it remains consistent with other axis conventions (e.g., pitch and roll) and with any assumptions in consumers of `output_data.gimbal.yaw` to avoid unintuitive control behavior.
- If this sign flip is intentional to match a specific hardware or user-control convention, consider adding a brief inline comment explaining the rationale so future maintainers understand why yaw uses this direction.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}