Skip to content

update go version to v1.26.4#426

Merged
Q7DF1 merged 1 commit into
mainfrom
feature/GO_VERSION_1_26_4
Jun 17, 2026
Merged

update go version to v1.26.4#426
Q7DF1 merged 1 commit into
mainfrom
feature/GO_VERSION_1_26_4

Conversation

@Q7DF1

@Q7DF1 Q7DF1 commented Jun 17, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version to 1.26.4 and adds the -checklinkname=0 flag to the Go linker flags in app/build.gradle.kts. Feedback is provided regarding the use of -checklinkname=0, which disables strict linker checks and introduces stability and compatibility risks. It is recommended to update the dependencies causing this issue or at least document this workaround with a TODO comment for future removal.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread app/build.gradle.kts
"-trimpath",
"-androidapi", "21",
"-ldflags=-s -w -buildid=",
"-ldflags=-s -w -buildid= -checklinkname=0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using -checklinkname=0 disables the Go linker's strict checks for unallowed //go:linkname directives. While this serves as a temporary workaround to get the build passing, it introduces stability and maintainability risks:

  1. Stability Risk: It allows linking against internal, unexported Go runtime/standard library APIs. These internal APIs are not covered by Go's compatibility promise and can change or be removed in any Go release, potentially causing runtime crashes.
  2. Future Compatibility: This flag is a transitional workaround and may be removed or restricted in future Go versions.

Recommendation: Consider identifying the dependencies (such as Xray/V2Ray core or other Go libraries) that rely on invalid //go:linkname references and update them to compliant versions. If this workaround must be kept for now, please document it with a TODO comment so it can be tracked and removed later.

        "-ldflags=-s -w -buildid= -checklinkname=0", // TODO: Remove once dependencies are updated to comply with Go's linkname restrictions

@Q7DF1 Q7DF1 merged commit c6b772d into main Jun 17, 2026
2 checks passed
@Q7DF1 Q7DF1 deleted the feature/GO_VERSION_1_26_4 branch June 18, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant