Enable Apple Silicon-ready build setup and remove vendored Sparkle dependency#102
Open
keramzyt wants to merge 3 commits into
Open
Enable Apple Silicon-ready build setup and remove vendored Sparkle dependency#102keramzyt wants to merge 3 commits into
keramzyt wants to merge 3 commits into
Conversation
…pendency Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates Fluor’s macOS build setup to be Apple Silicon-ready and removes a non-reproducible dependency on a locally vendored Sparkle.framework.
Background
The project referenced Sparkle.framework from a local path outside the repository. That made clean builds fragile across machines and difficult to maintain.
At the same time, target architecture settings were not explicitly aligned with modern standard macOS multi-arch expectations.
What changed
• Removed all Sparkle.framework references from Fluor.xcodeproj (linking + embedding).
• Removed obsolete Sparkle entries from .gitignore.
• Added Fluor/Misc/SUUpdater.swift as a compatibility class for existing storyboard SUUpdater bindings and actions.
• Preserved update UX by opening the latest GitHub release page and updating lastUpdateCheckDate for UI data bindings.
• Updated target build settings:
◦ ARCHS = $(ARCHS_STANDARD) (Debug + Release)
◦ ONLY_ACTIVE_ARCH = NO (Release)
Validation
• plutil -lint Fluor.xcodeproj/project.pbxproj ✅
• swiftc -typecheck Fluor/Misc/SUUpdater.swift ✅
• Full xcodebuild could not be validated in this environment due to a local Xcode plugin/runtime issue (IDESimulatorFoundation / DVTDownloads), unrelated to repository source changes.
Notes
This change prioritizes reproducible builds and architecture readiness.
If full in-app auto-update support is needed later, Sparkle should be reintroduced via a repository-managed dependency path (e.g. SPM), not as a local binary framework.