Conversation
Signed-off-by: Daniel Kampert <DanielKampert@kampis-elektroecke.de>
Closes: #24 Signed-off-by: Daniel Kampert <DanielKampert@kampis-elektroecke.de>
Signed-off-by: Daniel Kampert <DanielKampert@kampis-elektroecke.de>
- The camera PWD signal is now used as a separate signal - Solves incompatible signal levels for both enable pins - Fix DRC issues Signed-off-by: Daniel Kampert <DanielKampert@kampis-elektroecke.de>
- Some camera module require a GND connection on this pin - CHANGELOG fixes Signed-off-by: Daniel Kampert <DanielKampert@kampis-elektroecke.de>
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR modifies a PCB project's KiCad schematics and GitHub Actions workflow, updating component placements and test points, remapping display pin labels, renaming camera power signal nets (Camera-PWR to Camera-PWD), and adjusting BOM/DNP flags across multiple schematic sheets. The KiBot workflow default variant changes from Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR prepares the hardware design repo for the “Release 1.0.3” milestone, updating schematics/docs and release automation metadata.
Changes:
- Updates multiple KiCad schematics (camera PWD signal routing, added/adjusted passives/testpoints, net/label and wiring tweaks).
- Updates release/CI metadata (CHANGELOG formatting/entries and KiBot workflow variant).
- Updates KiCad project settings and documentation diagram content.
Reviewed changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
mainboard/SD.kicad_sch |
Adds a decoupling capacitor and related wiring/power symbol ref updates. |
mainboard/Project Architecture.kicad_sch |
Adjusts junctions/wiring and adds hierarchical pin for Camera-PWD. |
mainboard/Power.kicad_sch |
Updates component metadata (datasheets/part numbers) and sets several resistors to DNP/in_bom no. |
mainboard/Peripherals.kicad_sch |
Adds Camera-PWD hierarchical label, modifies wiring/junctions, and adjusts labels/references/testpoints. |
mainboard/Mainboard.kicad_pro |
Changes last-used/export paths and BOM grouping settings. |
mainboard/Lepton.kicad_sch |
Adds TestPoint library symbol definition and a new testpoint instance/wiring. |
mainboard/Display.kicad_sch |
Updates pin-description text annotations. |
mainboard/Camera.kicad_sch |
Renames Camera-PWR → Camera-PWD labels/port and adds an optional GND connection (AF pin 24). |
mainboard/Battery.kicad_sch |
Adds a new testpoint and related wiring/junction. |
mainboard/CHANGELOG.md |
Reworks changelog format and adds new entries. |
docs/Mainboard.drawio |
Updates diagram XML formatting/content (incl. ToF address text). |
.github/workflows/pcb.yml |
Changes default kibot_variant to PRELIMINARY. |
Comments suppressed due to low confidence (1)
mainboard/Mainboard.kicad_pro:571
pos_filesnow points to a user-specific../../../../../Downloads/directory. This makes the project non-portable and can leak local environment details; please revert to an empty string or a path relative to the repo (e.g., underproduction/).
"last_paths": {
"gencad": "",
"idf": "",
"netlist": "",
"plot": "../production/",
"pos_files": "../../../../../Downloads/",
"specctra_dsn": "",
"step": "../../../../../Downloads/Mainboard.step",
"svg": "",
"vrml": "../cad/ZSWatch.wrl"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # CHECKED: Will generate both schematic and PCB documents, with ERC/DRC | ||
| # RELEASED: Similar to CHECKED, automatically selected when pushing a tag to main | ||
| kibot_variant: CHECKED | ||
| kibot_variant: PRELIMINARY |
There was a problem hiding this comment.
kibot_variant was changed from CHECKED to PRELIMINARY, which (per the comment above) disables ERC/DRC on branch pushes. If the intent is to keep automated design-rule validation in CI, revert this to CHECKED (or make PRELIMINARY opt-in only for specific workflows/branches).
| kibot_variant: PRELIMINARY | |
| kibot_variant: CHECKED |
| "net_format_name": "", | ||
| "page_layout_descr_file": "${KIPRJMOD}/templates/KDT_Template_GIT.kicad_wks", | ||
| "plot_directory": "", | ||
| "plot_directory": "../../../../../Downloads/", |
There was a problem hiding this comment.
plot_directory was changed to a user-specific ../../../../../Downloads/ path. This will break plotting/export on other machines and in CI; please set it to a project-relative directory (or leave it empty so KiCad defaults apply).
| "plot_directory": "../../../../../Downloads/", | |
| "plot_directory": "", |
| ## [Unreleased](https://github.com/PyroVision-ThermalCam/Mainboard/compare/1.0.2...HEAD) | ||
|
|
||
| ## [1.0.2] - 2026-02-24 | ||
| **Added:** | ||
|
|
||
| - Add optional GND connection for camera AF on pin 24 | ||
|
|
||
| **Removed:** | ||
|
|
||
| - Remove camera PWD signal from camera power supply enable | ||
|
|
||
| ## [1.0.2](https://github.com/PyroVision-ThermalCam/Mainboard/compare/1.0.1...1.0.2) - 2026-02-24 | ||
|
|
||
| **Fixed:** | ||
|
|
||
| - Add missing name for net for TP701 (#11) | ||
| - Wrong part number for IC804 (#17) | ||
| - Wrong part number for DFE201610E - R47M (#16) | ||
| - IC806 is set to DNP (#14) | ||
| * Add missing name for net for TP701 (#11) | ||
| * Wrong part number for IC804 (#17) | ||
| * Wrong part number for DFE201610E - R47M (#16) | ||
| * IC806 is set to DNP (#14) | ||
| * Remove camera PWD signal from camera power supply enable | ||
|
|
||
| **Added:** | ||
|
|
||
| - Connect the TMP117 temperature alert pin (#21) | ||
| * Connect the TMP117 temperature alert pin (#21) | ||
| * Add missing GND connection for camera AF on pin 24 |
There was a problem hiding this comment.
This changelog update doesn’t add a 1.0.3 section even though the PR is titled "Release 1.0.3", and it also adds new items into the existing 1.0.2 section. Please move the new entries into a new ## [1.0.3] - YYYY-MM-DD section (with the correct compare link), and keep [Unreleased] for changes not yet released.
Summary by CodeRabbit
New Features
Bug Fixes
Chores