Conversation
Signed-off-by: Daniel Kampert <DanielKampert@kampis-elektroecke.de>
|
Important Review skippedToo many files! This PR contains 153 files, which is 3 over the limit of 150. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (147)
📒 Files selected for processing (153)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the 1.0.1 release packaging/automation by removing generated production artifacts, adjusting KiBot logo-copy output paths, and adding CI utilities for changelog validation and dev-branch creation.
Changes:
- Remove generated KiRI/HTML “navigate” artifacts from
production/displayboard-RELEASED/*. - Update KiBot configuration and README/template logo paths (new logo location + output directory change).
- Add CI workflows/scripts for changelog validation and automated dev-branch creation; tweak PCB workflow artifact naming and pre-steps.
Reviewed changes
Copilot reviewed 149 out of 400 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| production/displayboard-RELEASED/KiRI/local/KIRI/pcb/.layer-27.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/local/KIRI/pcb/.layer-25.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/local/KIRI/pcb/.layer-23.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/local/KIRI/pcb/.layer-21.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/local/KIRI/pcb/.layer-19.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/local/KIRI/pcb/.layer-17.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/local/KIRI/pcb/.layer-15.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/local/KIRI/pcb/.layer-13.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/local/KIRI/pcb/.layer-11.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/local/KIRI/pcb/.layer-09.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/local/KIRI/pcb/.layer-07.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/local/KIRI/pcb/.layer-05.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/local/KIRI/pcb/.layer-03.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/local/KIRI/pcb/.layer-02.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/local/KIRI/pcb/.layer-01.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/local/KIRI/pcb/.layer-00.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/sch_sheets | Removes generated KiRI schematic sheet index from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/sch/.options.json | Removes generated KiRI schematic options metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb_layers | Removes generated KiRI PCB layer list from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-59.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-57.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-55.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-53.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-51.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-49.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-47.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-45.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-43.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-41.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-39.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-35.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-33.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-31.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-29.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-27.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-25.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-23.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-21.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-19.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-17.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-15.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-13.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-11.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-09.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-07.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-05.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-03.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-02.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-01.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/9701a2d/KIRI/pcb/.layer-00.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/sch_sheets | Removes generated KiRI schematic sheet index from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/sch/.options.json | Removes generated KiRI schematic options metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb_layers | Removes generated KiRI PCB layer list from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-59.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-57.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-55.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-53.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-51.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-49.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-47.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-45.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-43.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-41.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-39.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-35.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-33.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-31.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-29.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-27.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-25.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-23.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-21.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-19.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-17.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-15.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-13.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-11.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-09.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-07.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-05.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-03.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-02.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-01.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/8ee94aa/KIRI/pcb/.layer-00.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/sch_sheets | Removes generated KiRI schematic sheet index from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/sch/.options.json | Removes generated KiRI schematic options metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb_layers | Removes generated KiRI PCB layer list from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-59.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-57.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-55.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-53.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-51.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-49.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-47.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-45.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-43.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-41.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-39.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-35.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-33.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-31.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-29.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-27.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-25.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-23.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-21.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-19.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-17.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-15.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-13.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-11.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-09.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-07.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-05.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-03.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-02.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-01.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/KiRI/81597f3/KIRI/pcb/.layer-00.svg.json | Removes generated KiRI PCB layer metadata from released artifacts. |
| production/displayboard-RELEASED/HTML/Displayboard-navigate_Testing.html | Removes generated HTML navigation page from released artifacts. |
| production/displayboard-RELEASED/HTML/Displayboard-navigate_PCB_docs.html | Removes generated HTML navigation page from released artifacts. |
| production/displayboard-RELEASED/HTML/Displayboard-navigate_PCB.html | Removes generated HTML navigation page from released artifacts. |
| production/displayboard-RELEASED/HTML/Displayboard-navigate_Netlist.html | Removes generated HTML navigation page from released artifacts. |
| production/displayboard-RELEASED/HTML/Displayboard-navigate_Manufacturing.html | Removes generated HTML navigation page from released artifacts. |
| production/displayboard-RELEASED/HTML/Displayboard-navigate_KiRI.html | Removes generated HTML navigation page from released artifacts. |
| production/displayboard-RELEASED/HTML/Displayboard-navigate_KiCanvas.html | Removes generated HTML navigation page from released artifacts. |
| production/displayboard-RELEASED/HTML/Displayboard-navigate_3D.html | Removes generated HTML navigation page from released artifacts. |
| displayboard/kibot_yaml/kibot_out_logo_copy.yaml | Updates KiBot “copy logo” output to use new constants and explicit output directory. |
| displayboard/kibot_yaml/kibot_main.yaml | Updates KiBot import definitions and logo path; changes copy destination directory. |
| displayboard/kibot_resources/templates/readme.txt | Updates generated README template to reference new logo location. |
| displayboard/README.md | Updates README to reference new logo location. |
| displayboard/CHANGELOG.md | Adds unreleased items and changes section formatting. |
| .github/workflows/pcb.yml | Adjusts default KiBot variant, artifact naming, changelog action version, and a sed pre-step. |
| .github/workflows/create-dev-branch.yml | Adds workflow to create and initialize versioned development branches. |
| .github/workflows/changelog-check.yaml | Adds workflow to validate changelog formatting and issue references. |
| .github/scripts/create-dev-branch.sh | Adds bash script to create and initialize versioned development branches. |
| .github/scripts/create-dev-branch.ps1 | Adds PowerShell script to create and initialize versioned development branches. |
| .github/.commit-msg-template | Adds a commit message template used by automation/scripts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Validate Changelog Format | ||
| shell: bash | ||
| run: | | ||
| CHANGELOG_FILE="CHANGELOG.md" |
There was a problem hiding this comment.
This workflow validates CHANGELOG.md at the repository root, but the changelog modified in this PR is displayboard/CHANGELOG.md. As written, the workflow will fail (file not found) or validate the wrong file. Update CHANGELOG_FILE to the correct path (or parameterize it to match pcb.yml’s changelogPath).
Comment on lines
+5
to
+12
| **Changed:** | ||
|
|
||
| - Replace JS1400BFQ with MU-BUE70R | ||
| - Replace NPN transistor with N-Channel MOSFET | ||
|
|
||
| **Added:** | ||
|
|
||
| - Add debounce capacitors for push buttons |
There was a problem hiding this comment.
The changelog formatting was changed from Keep a Changelog-style headings (e.g., ### Added) to bold labels (**Added:**). This is likely to break tooling that expects standard headings (notably the keep-a-changelog-new-release GitHub Action used in pcb.yml) and also conflicts with the validation rules in changelog-check.yaml (which look for ### Added/Changed/Fixed/Removed). Prefer restoring standard ### headings under each release/section, or update the tooling/validator to match the new format.
| ## [1.0.0] - 2026-01-17 | ||
|
|
||
| ### Added | ||
| **Added:** |
There was a problem hiding this comment.
The changelog formatting was changed from Keep a Changelog-style headings (e.g., ### Added) to bold labels (**Added:**). This is likely to break tooling that expects standard headings (notably the keep-a-changelog-new-release GitHub Action used in pcb.yml) and also conflicts with the validation rules in changelog-check.yaml (which look for ### Added/Changed/Fixed/Removed). Prefer restoring standard ### headings under each release/section, or update the tooling/validator to match the new format.
Comment on lines
8
to
+14
| - name: @NAME@ | ||
| comment: '@COMMENT@' | ||
| type: copy_files | ||
| dir: '@OUTDIR@' | ||
| options: | ||
| files: | ||
| - source: @LOGO@ | ||
| - source: @SOURCE@ |
There was a problem hiding this comment.
The KiBot logo-copy output now copies a single file into @OUTDIR@ (default .), but the README/template in this PR reference Images/Logos/Logo.png. With the current config, the copied file name/path is unlikely to end up under Images/Logos/ unless the copy step explicitly preserves/creates that subdirectory. Align the documentation path with the actual output location, or update the copy output to place the logo at Images/Logos/Logo.png (e.g., by copying into an Images/Logos outdir or using an explicit destination path if supported).
| DESIGNER: Daniel Kampert | ||
|
|
||
| LOGO: 'logos/Logo.png' | ||
| LOGO: 'Logos/Logo.png' |
There was a problem hiding this comment.
This changes the logo source path from logos/Logo.png to Logos/Logo.png (case change) without any corresponding file rename shown in the PR. On case-sensitive filesystems (including GitHub Actions runners), this will break if the actual directory is still logos/. Either include the directory rename in the PR, or keep the path casing consistent with the repository.
Suggested change
| LOGO: 'Logos/Logo.png' | |
| LOGO: 'logos/Logo.png' |
| 3D_DIR: '3D' | ||
| NETLIST_DIR: 'Netlist' | ||
| COPY_LOGO_DIR: '.' | ||
| COPY_LOGO_DIR: 'Images' |
There was a problem hiding this comment.
This changes the logo source path from logos/Logo.png to Logos/Logo.png (case change) without any corresponding file rename shown in the PR. On case-sensitive filesystems (including GitHub Actions runners), this will break if the actual directory is still logos/. Either include the directory rename in the PR, or keep the path casing consistent with the repository.
| @@ -2,11 +2,20 @@ | |||
|
|
|||
| ## [Unreleased] | |||
There was a problem hiding this comment.
PR title indicates a Release 1.0.1, but the changelog changes only add items under [Unreleased] and do not introduce a [1.0.1] - <date> section. If this PR is meant to be the 1.0.1 release commit/tag, consider moving these entries into a ## [1.0.1] - YYYY-MM-DD section (leaving [Unreleased] empty or with upcoming changes).
- Update thomaseizinger/keep-a-changelog-new-release to version 3 Closes #10 Signed-off-by: Daniel Kampert <DanielKampert@kampis-elektroecke.de>
Signed-off-by: Daniel Kampert <danielkampert@kampis-elektroecke.de>
Signed-off-by: Daniel Kampert <DanielKampert@kampis-elektroecke.de>
- Replace JS1400BFQ with MU-BUE70R - Add CI/CD workflow to check for changelog updates on PRs Closes #19 Signed-off-by: Daniel Kampert <DanielKampert@kampis-elektroecke.de>
…rovements Signed-off-by: Daniel Kampert <DanielKampert@kampis-elektroecke.de>
- Replace NPN transistor with N-Channel MOSFET Signed-off-by: Daniel Kampert <DanielKampert@kampis-elektroecke.de>
Signed-off-by: Daniel Kampert <DanielKampert@kampis-elektroecke.de>
Kampi
force-pushed
the
master
branch
4 times, most recently
from
90544c6 to
6597902
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.