Skip to content

fix: disambiguate exception imports in Bluesky client#28

Merged
Pymetheus merged 1 commit into
mainfrom
develop
May 22, 2026
Merged

fix: disambiguate exception imports in Bluesky client#28
Pymetheus merged 1 commit into
mainfrom
develop

Conversation

@Pymetheus
Copy link
Copy Markdown
Owner

Description

Avoid a name collision between atproto_client and httpx exceptions by aliasing atproto_client.exceptions.InvokeTimeoutError and NetworkError to AtprotoInvokeTimeoutError and AtprotoNetworkError, and update the except clause to catch those aliases. This ensures the BlueskyAPIClient correctly handles atproto client timeouts and network errors without confusing them with httpx.NetworkError.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Related Issue

Closes #(issue number)

Changes Made

  • Avoid a name collision between atproto_client and httpx exceptions

Testing

Describe how you tested your changes:

  • Unit tests pass
  • Integration tests pass
  • Manual testing performed

Screenshots (if applicable)

Add screenshots to help explain your changes.

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Context

Add any other context about the PR here.

Avoid a name collision between atproto_client and httpx exceptions by aliasing atproto_client.exceptions.InvokeTimeoutError and NetworkError to AtprotoInvokeTimeoutError and AtprotoNetworkError, and update the except clause to catch those aliases. This ensures the BlueskyAPIClient correctly handles atproto client timeouts and network errors without confusing them with httpx.NetworkError.
@github-actions github-actions Bot added the bug Types: Something is broken or not working label May 22, 2026
@Pymetheus Pymetheus merged commit 02bd460 into main May 22, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Types: Something is broken or not working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant