add HttpHeaderCSRFStoragePolicy#3779
Draft
silenius wants to merge 4 commits into
Draft
Conversation
Contributor
|
This CSRF policy pulls from |
Contributor
Author
|
that's right, I missed that..! is using a different key in the CSRF policy an acceptable solution or too fragile? |
Contributor
|
Hard to say, I don't really understand where or how one might use this policy. Can you give a sample use case? |
Contributor
Author
|
I just want to store the CSRF token in an header rather than in the session or in a cookie. I'm using JWT tokens and it is often recommended to store the JWT token in a secure onlyHTTP same-site cookie and the CSRF token in header |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
HttpHeaderCSRFStoragePolicyto persists the CSRF token in an HTTP header.While here, also replace
uuid.uuid4()withsecrets.token_hex()for the token factory