fix route_prefix leading slash handling#3759
Open
fmigneault wants to merge 2 commits into
Open
Conversation
Author
|
@mmerickel FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3758
In summary, applies the proposed
strip->rstripmodification toroute_prefixhandling such that the resultingroute_prefixin the configurator keeps the leading/if explicitly specified. If not specified (i.e.:route_prefix="prefix"instead ofroute_prefix="/prefix"), it results in the same behavior as before.When merging/nesting multiple paths/routes onto each other, insertion of the
/is applied automatically as needed (as it was before, but considering/prefixmust be kept instead ofprefix).Added exhaustive test combinations for combining
config.include(route_prefix=...),with config.route_prefix_context(route_prefix=...)with direct/nested configurators and with/without explicit leading slash.