Tidy up codebase#106
Closed
KJonline wants to merge 7 commits into
Closed
Conversation
added 4 commits
November 9, 2025 23:44
…objects - Changed from bracket notation (device["hiveID"]) to dot notation (device.hive_id) throughout action, alarm, camera, and heating modules - Updated AWS Cognito client initialization to use unsigned config instead of placeholder credentials - Replaced device.get() with getattr() for optional attributes
- Fixed sys.settrace implementation to properly enable/disable tracing - Renamed variables to follow Python naming conventions (snake_case) - Added proper return values to trace functions and __exit__ method
- Renamed token attributes from camelCase to snake_case (tokenData → token_data, tokenCreated → token_created, tokenExpiry → token_expiry) - Renamed config attributes to snake_case (homeID → home_id, lastUpdated → last_updated, scanInterval → scan_interval, userID → user_id)
…ctionality Deleted alarm.py and camera.py modules containing HiveHomeShield/Alarm and HiveCamera/Camera classes. Removed alarm and camera-related API endpoints from both hive_api.py and hive_async_api.py including security-lite, camera images, and camera recordings URLs. Removed camera-specific request handling with Bearer token authentication and x-jwt-token headers. Cleaned up cameraBaseUrl and cameraPlatform references from
Renamed camelCase attributes to snake_case: tokenData to token_data, deviceList to device_list, tokenCreated to token_created, and tokenExpiry to token_expiry. Updated all references throughout hive_async_api.py and session.py to maintain consistency with Python naming conventions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.