ci: cut fixed setup overhead in test jobs#3269
Merged
Merged
Conversation
Warm-run step timings show the remaining fixed overhead per matrix cell is concentrated in two steps: - The zig cross-compile step ran 'cargo run build', which rebuilt maturin with default features because the nextest step builds it with --features password-storage,faster-tests. Use the already-built target/debug/maturin instead, like the subsequent steps do (zig is in the default feature set). This was 1m39-3m54 per cell. - setup-miniconda took up to 2 minutes on Windows. Switch to setup-micromamba (binary-only install, seconds) and teach the test harness to fall back to micromamba when conda is absent; conda and micromamba share the create CLI and the --json output fields the harness parses, and micromamba also creates the test envs ~2.5x faster. An explicit --root-prefix under test-crates keeps it working when MAMBA_ROOT_PREFIX is not set. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NNNLg7XZnxM8Aiqrzo6c5q
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third round for #2189. After #3267 and #3268, warm-run step timings show the test phase is no longer the bottleneck in several cells — fixed setup steps are. Per matrix cell the remaining overhead concentrates in exactly two steps; this PR addresses both.
zig cross-compile step: use the prebuilt maturin (was 1m39–3m54 per cell)
The step ran
cargo run build ..., which rebuilt maturin with default features — thecargo teststep builds it with--features password-storage,faster-tests, so the feature sets differ and cargo rebuilds the binary and its dependency tree. ThePYO3_CONFIG_FILEandmaturin newsteps that follow already usetarget/debug/maturindirectly; the zig step now does the same (zigis in the default feature set viacross-compile, so the nextest-built binary supports--zig). Most of the step's time was this rebuild, not the zig builds themselves.setup-miniconda → setup-micromamba (was up to 2m on Windows)
setup-micromambain binary-only mode installs in seconds. The test harness now falls back to micromamba whencondais absent: conda and micromamba share thecreate -n NAME python=X.Y -q -y --jsonCLI, and micromamba's JSON output has the same top-levelprefix/successfields the harness already parses. An explicit--root-prefixundertest-crates/venvskeeps it working whenMAMBA_ROOT_PREFIXisn't set.Verified locally with conda removed from PATH:
develop_pyo3_pure_condapasses through the micromamba path — and runs ~2.5× faster (36s vs ~90s), since micromamba also creates the conda envs much faster than conda does. Repeatcreateover an existing env is idempotent.Expected effect
Windows 3.9 (currently the long pole at ~17m53 warm with only 6m36 of actual tests): roughly −2m from the zig step rebuild and −1m40 from miniconda, plus faster conda env creation inside the conda tests. Similar cuts on the other cells running those steps.
🤖 Generated with Claude Code
https://claude.ai/code/session_01NNNLg7XZnxM8Aiqrzo6c5q