fix(viz): assert fit_quick.png, the real lens quick-update artifact#159
Merged
Conversation
The modeling_visualization_jit Part-2 assertions globbed for fit.png, but the lens quick-update visualizer writes fit_quick.png (via subplot_fit_quick), so the assertion always failed with 'no fit.png produced — quick-update did not fire' even though quick-update fired correctly. Verified against a real Nautilus run: the imaging search produces .../image/fit_quick.png. Update the glob, prints, assertion message and stale comments to the correct filename in the imaging, interferometer and point_source scripts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scripts/{imaging,interferometer,point_source}/modeling_visualization_jit.pyfail in the release-fidelity Workspace Validation matrix with:The Part-2 assertion globs
rglob("fit.png"), but the lens quick-update visualizer writesfit_quick.png(viasubplot_fit_quick,output_filename="fit_quick"), notfit.png. So the assertion failed deterministically even though quick-update fired correctly.Root cause
Verified against a real local Nautilus run of the imaging script: the search produces
output/.../mge_linear/<hash>/image/fit_quick.png(+dataset.png).rglob("fit.png")→ 0 matches;rglob("fit_quick.png")→ 1 match. The quick-update fired; the test looked for the wrong filename (library artifact name the test was never updated to).Fix
Update the glob, prints, assertion message and stale comments to
fit_quick.pngin the three lens scripts. Intent (verify quick-update fires and writes its fit subplot) is unchanged.Verification
rglob("fit_quick.png")finds the real artifact from the produced output tree (0 → 1). Full end-to-end run is gated on this laptop by the Part-1 hardware-dependent perf assertion (warm_dt < 0.1), which is unrelated to this fix and passes on the faster CI runners.Scope note
This covers only the lens scripts (autolens_workspace_test). The sibling
autogalaxy_workspace_testimaging/interferometer scripts writefit.png(different plotter) yet also fail — that is a different root cause under investigation via a fresh validation run; ellipse likewise. Those are out of scope here.pending-release