fix: restore release result contracts#229
Merged
Merged
Conversation
This was referenced Jul 6, 2026
There was a problem hiding this comment.
Pull request overview
This pull request restores the expected “release-fidelity” results outputs for the results tutorials, ensuring the tutorials can reliably demonstrate indexed sample access and reload saved FITS datasets without failing noise-map validation.
Changes:
- Disable noise-map validation when reloading saved
dataset.fitsproducts in the resultsstart_hereguide (check_noise_map=False) to allow masked zero-valued noise pixels. - Ensure the results quick-fit helper retains all samples by disabling output-side weight threshold filtering (
samples_weight_threshold = None). - Align results tutorial prose with the existing “tenth-last sample” indexing contract and adjust release env vars to run results guides with
PYAUTO_TEST_MODE=0.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/guides/results/start_here.py | Loads saved FITS dataset products with check_noise_map=False to support masked zero-noise pixels. |
| scripts/guides/results/aggregator/galaxies_fits.py | Updates narrative text to match tenth-last sample indexing used in code. |
| scripts/guides/results/_quick_fit.py | Disables sample-weight threshold filtering so results guides can demonstrate indexed sample access over the full capped sample set. |
| notebooks/guides/results/start_here.ipynb | Regenerated notebook reflecting the check_noise_map=False change from the script. |
| notebooks/guides/results/aggregator/galaxies_fits.ipynb | Regenerated notebook reflecting the prose update from the script. |
| notebooks/guides/results/_quick_fit.ipynb | Regenerated notebook reflecting the config override to retain all samples. |
| config/build/env_vars_release.yaml | Forces PYAUTO_TEST_MODE=0 for results guides in the release profile to preserve expected sample/output contracts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore release-fidelity result generation, centralize results workflow setup through
_quick_fit.py, preserve the fixed tenth-sample tutorial contract, and correctly load saved masked imaging datasets.Scripts Changed
scripts/guides/results/_quick_fit.py— now creates two capped Nautilus fits in plainoutput/results_folder, retains all 300 samples, writes latent summaries, and disables fast-plot skipping so PNG/FITS workflow products exist.scripts/guides/results/workflow/{csv_make,png_make,fits_make}.py— reuse_quick_fit.pyinstead of duplicating their own two-fit setup; aggregate fromresults_folderinstead ofresults_folder_csv_png_fits.scripts/guides/results/aggregator/*— use plainPath("output") / "results_folder"; no workspace-side test-mode path handling.scripts/guides/results/aggregator/galaxies_fits.py— correct prose to match tenth-last sample access.scripts/guides/results/start_here.py— useresults_folderfor the quick workflow output path and allow masked zero-valued noise pixels when reloading saved dataset FITS.config/build/env_vars_release.yaml— unsetPYAUTO_TEST_MODEfor results guides so they run outside PyAuto test mode.Test Plan
csv_make.pycreates all seven expected CSV files_quick_fit.pypasses withPYAUTO_TEST_MODEunset, 300 retained rows, and nooutput/test_mode/results_foldercsv_make.py,png_make.py,fits_make.pyreuse two centralized fits with latent summaries,fit.png, andfit.fitsunderoutput/results_folder; noresults_folder_csv_png_fitsis createdwith_test_mode_segment,PYAUTO_TEST_MODE, oroutput/test_modereferences remain inscripts/guides/results🤖 Generated with Codex