refactor: unify the blurred-image evaluate/pre-bin/convolve tail#489
Merged
Conversation
…ge variants (#488) Proper Refactor Agent run on the k x s surface (RefactorDecision: too-large -> conservative cut; invariant = witnesses unchanged). The three blurred-image variants each re-implemented the same tail; one _convolved_from_evaluations core now carries it (oversampled: pre-bin + fine convolution; regular: delegate to _blurred_image_2d_from). The dict variant's s=1 path now routes through _blurred_image_2d_from — the same psf.convolved_image_from call it made directly, verified identical by the witnesses. PyAutoArray surface assessed in place, no edits: the util pair, mapper property/method pair and divisibility validator are each single-purpose and already minimal; the segment-mean xp split intentionally mirrors OverSampler.binned_array_2d_from. Recorded on #488. Witnesses: PyAutoGalaxy 956 / PyAutoArray 867 / PyAutoLens 347 / full convolution_over_sampled.py (14 sections) — all unchanged, zero test edits. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proper Refactor Agent pass on the k×s surface (#488; decision: too-large → conservative cut). One
_convolved_from_evaluationscore replaces the tail re-implemented in all three blurred-image variants. PyAutoArray surface assessed clean, no edits (details on the issue). Witnesses all green unchanged: PyAutoGalaxy 956 / PyAutoArray 867 / PyAutoLens 347 / the 14-section workspace k×s script. Zero test edits, no API change.🤖 Generated with Claude Code