feat: oversampled PSF support in SimulatorImaging (phase: simulator)#483
Merged
Conversation
OperateImage.convolved_padded_image_2d_from (shared by Galaxies and Tracer): builds the padded all-false frame from the kernel's image-resolution footprint with a uniform over-sample size (the regular padded grid pads its border with size-1 entries, which the uniformity guard correctly rejects), evaluates unbinned on the padded over-sampled coordinates, convolves at the fine resolution and returns the image-resolution convolved padded image; operated profiles are added unblurred as elsewhere. via_galaxies_from switches on psf.convolve_over_sample_size > 1 and passes image_is_convolved=True to the base simulator, trimming with kernel_shape_image_resolution. s=1 path byte-identical. Delta-kernel identity unit test for the padded-frame geometry. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #482:
OperateImage.convolved_padded_image_2d_from(shared by Galaxies and Tracer — uniform-s padded frame, fine evaluation + convolution, image-resolution output, operated profiles added unblurred) and thevia_galaxies_fromswitch withimage_is_convolved=Truepass-through. s=1 byte-identical. Tests: delta-kernel padded-frame identity (1e-14) + simulate-and-fit round trip at s=2 (chi²≈0). Suite: 946 passed. Merge after PyAutoArray'simage_is_convolvedPR.🤖 Generated with Claude Code