feature/declarative deterministic#1153
Merged
Merged
Conversation
Jammy2211
approved these changes
Sep 22, 2025
This was referenced Jul 8, 2026
Jammy2211
pushed a commit
that referenced
this pull request
Jul 8, 2026
…ests - autofit/graphical/README.md: new §8 'The lowering contract (declarative → graph)' — every declarative concept and what it lowers to, with invariants (compound priors add no variables; factor_out not reachable by design; PriorFactor exact-hooks gap noted → #1337/#1338). - AGENTS.md: the EP seam rule — inner-layer capability lands in the same PR as its declarative expression or an explicit 'not exposed' entry, plus a seam test. - test_autofit/graphical/test_declarative_deterministic.py: replaced the commented-out PR #1153 illustration with 4 working seam tests pinning the explicit compound-prior lowering (no new variables, graph shape, in-factor realisation, shared-variable connectivity). The model.<property> sugar remains deliberately reverted (be64117). EP review seam recommendations (#1330 wrap-up discussion); Phase 5 recommendation A item 2 delivered independently of the #1336 decision. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
illustration of creating declarative, deterministic graph using compound priors
Also adds syntactic sugar where you can do this:
As af.Gaussian.fwhm is a property that is a function of the arguments to the class, model.fwhm is now a compound prior