refactor: vectorize k×s segment-id construction#365
Merged
Conversation
…cise) The per-pixel python loop becomes pure numpy (repeat/cumsum/divmod on the flat sample index): cold construction 62 ms -> 9.7 ms on a 3000-pixel adaptive mask (cached repeat calls unchanged at ~80 us). Exact same ids as the loop on adaptive references; suite unchanged. Behaviour-preserving; closes the library leg of the k x s refactor exercise. The operate/image call-site pattern was reviewed and left as-is (clean two-step seam); no PyAutoGalaxy edits needed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The k×s refactor exercise's library leg (#362, sequenced after phase 3 — merged this morning as autolens_workspace_test#154): the per-pixel loop in
convolve_bin_segment_ids_frombecomes pure numpy. Cold construction 62→9.7 ms on a 3000-pixel adaptive mask; ids bit-identical to the loop; suite 867 unchanged, zero test edits. Call-site review found the operate/image seam clean as-is (no PyAutoGalaxy changes needed, so no claim contention).🤖 Generated with Claude Code