Test ci#1
Open
Punpun1643 wants to merge 40 commits into
Open
Conversation
…hingservice_selectionview UI for selection of question difficulty
There is no countdown timer for matching services. 30 seconds countdown timer is required to match users. Let's implement a UI for the countdown timer so that the users can visually see how long the matching service has in order to find a match before it times out.
…ocket-server-instance Initialize socket server instance
…l and ORM layer Implementations: * Create database connection with nodejs * Implement the pending match model * Implement the ORM layer. This layer will serve as an 'intermediary' between the controller and the database. Additionally, Implemented CRUD features + useful features: - Add new pending match (`POST` request to `localhost:8001/pendingMatches` with the *JSON* object) - Delete existing pending match (`DELETE` request to `localhost:8001/pendingMatches/:username`) - Update difficulty level for pending match (`PUT` request to `localhost:8001/pendingMatches/:username`) - Retrieve all pending match (`GET` request to `localhost:8001/pendingMatches`) - Find pending match by username (`GET` request to `localhost:8001/pendingMatches/:username`)
Update ESLint from main branch. Sync matching-service with main.
ESLint check fails due to some check that does not align with Express. An update is required to ignore these checks. Include object-shorthand:0 to ignore necessary declarations for Express module exports. Include no-use-before-define to ignore functions as these need to be `used` before declarations following Express. Let's update ESLint to align with these requirements.
* Add package-lock.json * Add structural layout for room page * Add leave button * Edit dimensions * Edit dimensions * Modify layout according to feedback * Adjust border and margin * Remove comments * Fix eslint warnings
…nce when find match button is clicked * Create socket.io client instance upon clicking match button * Fix style check * Edit event emitted to include difficulty * Added event listeners on server side * Add routing from matching page to countdown timer * Change capitalisation of events emitted * Change capitalisation of events emitted * Implement countdown timer as modal * Add emit cancel-match events * Align emit event names * Align emit event names * Aign emit event names * Fix bug where event is emitted thrice and align event names
* Refactoring and add pending match upon match event * Change and add primary key to auto-incremented id * Implement no-match-found event * Match pending match by difficulty level * Minor abstraction * Abstract out repository * Fix match-hard pending match creation bug * Send match-success to matched users * Resolve bug for match-success hard * Update * Add no-match-found handler
…stances (CS3219-AY2223S1#81) * Support CRUD from different socket instances * Implement room joining and creation through socket * Implement room joining on matched * Implement no-match-found event * Implement match-cancel event * Implement leave-room event
* Modify match-cancel and no-match-found events to not pass data * Modify match-cancel and no-match-found events to not pass data * Add join-room event * add leave-room event * Pass socket to room * remove match-fail * Prevent both no-match-found and match-cancel events to be emitted * Merge with backend * create socket context * Add socket context to other views * Fix bug cannot leave room after refresh
* fix alignment issue for selection page * prevent leave room button from overflowing to code editor * add check modal for leave room
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.