Skip to content

Type checking using Ty#69

Merged
armanddidierjean merged 13 commits into
devfrom
ty-p
Apr 21, 2026
Merged

Type checking using Ty#69
armanddidierjean merged 13 commits into
devfrom
ty-p

Conversation

@armanddidierjean
Copy link
Copy Markdown

Description

Summary

Typecheck the codebase using ty in addition to mypy.

Ty was able to detect multiples type related issues in our current codebase that are fixed by this pull request. This pull request will also allow developpers to use Ty to typecheck their code in realtime during development.

Mypy is still able to detect some issues that Ty don't catch, and there are still a few bugs in Ty. The idea of this pull request is thus to run both typecheckers in the CI

Based on aeecleclair#954

Required PRs

Requires #68

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@armanddidierjean armanddidierjean changed the title Ty p Type checking using Ty Apr 20, 2026
# Conflicts:
#	requirements-dev.txt

# Conflicts:
#	requirements-dev.txt
# Conflicts:
#	app/core/checkout/endpoints_checkout.py
#	app/core/checkout/payment_tool.py
#	app/utils/initialization.py
# Conflicts:
#	app/core/checkout/payment_tool.py
to fix inconsistency with schemas
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

@armanddidierjean armanddidierjean merged commit f695d90 into dev Apr 21, 2026
6 checks passed
@armanddidierjean armanddidierjean deleted the ty-p branch April 21, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant