Add isValidSetpoint() - #97
Closed
kcooney wants to merge 1 commit into
Closed
Conversation
kcooney
force-pushed
the
kcooney/is-valid-setpoint
branch
3 times, most recently
from
December 30, 2025 23:41
e0f23ef to
a03a26e
Compare
kcooney
force-pushed
the
kcooney/revert-93
branch
2 times, most recently
from
January 3, 2026 02:15
181c7e1 to
63f7396
Compare
kcooney
force-pushed
the
kcooney/is-valid-setpoint
branch
from
January 3, 2026 02:15
a03a26e to
f01e9ea
Compare
kcooney
added a commit
that referenced
this pull request
Jan 3, 2026
kcooney
force-pushed
the
kcooney/is-valid-setpoint
branch
2 times, most recently
from
January 4, 2026 05:28
c9cb46f to
2037fbd
Compare
kcooney
force-pushed
the
kcooney/is-valid-setpoint
branch
from
January 4, 2026 22:03
2037fbd to
93c599d
Compare
Member
|
I'm not sure if this is really necessary, as couldn't this be implemented in the subclass. |
Contributor
Author
@spderman3333 we reverted #93 since Le Prawn wasn't extending |
kcooney
force-pushed
the
kcooney/is-valid-setpoint
branch
from
January 8, 2026 06:20
93c599d to
f76b6d4
Compare
kcooney
force-pushed
the
kcooney/is-valid-setpoint
branch
from
January 8, 2026 06:24
f76b6d4 to
a69e462
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposed extension point for the problem that motivated the changes in #93.
isValidateSetpoint()) that allows subclassesto determine that a provided setpoint is invalid
setSetpoint()to document that it will do nothing ifisValidateSetpoint()returns
falseNote: I went with this change, instead of making
setSetpoint()non-final, becauseif subclasses could override
setSetpoint()they could do almost anything (includingpassing a different setpoint to
super). These changes provide an API to allow theactual need (discarding values that are determined at runtime to be invalid).