-
Notifications
You must be signed in to change notification settings - Fork 0
Fixed the disable method in MotorSubystem (now called PositionalMotor… #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c646ea4
c6fdfa2
5d1390e
f53c6f0
14cfbb5
42d57ff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -132,3 +132,4 @@ fabric.properties | |
|
|
||
| # Exclude local preference files generated by VSCode editors. | ||
| .vscode/ | ||
| .idea/ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, keep config changes out of this PR. |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -162,10 +162,31 @@ public TalonFX motor() { | |
| return motor; | ||
| } | ||
|
|
||
| /** | ||
| * Sets the behavior the motor should exhibit upon receiving a request to stop: | ||
| * "<i>disable()</i>". | ||
| * | ||
| * <ul> | ||
| * <li>Coast: The motor stops applying an input, but continues to move with its inertia. | ||
| * <li>Brake: The motor stops applying an input, and actively opposes its inertia. | ||
| * </ul> | ||
|
Comment on lines
+169
to
+172
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Enumerating the neutral modes is probably a bad idea because they are already present in the Phoenix API docs, and may change in the future
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For now, its easier for anyone reading, that does not want to open a whole new tab. |
||
| * | ||
| * @param mode | ||
| */ | ||
| public void setNeutralMode(NeutralModeValue mode) { | ||
| motor.setNeutralMode(mode); | ||
| } | ||
|
|
||
| /** | ||
| * Sends a disable command to the motor, placing it in its neutral value. | ||
| * | ||
| * @see TalonFXWrapper#setNeutralMode(NeutralModeValue) | ||
| */ | ||
| @Override | ||
| public void disable() { | ||
| motor.disable(); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You are probably looking for
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @spderman3333 given all the confusion as to the behavior of |
||
| } | ||
|
|
||
| @Override | ||
| public void configPIDF(int slot, double p, double i, double d, double f) { | ||
| SlotConfigs conf = new SlotConfigs(); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we actually want to remove the entire .idea directory.
If we want it to be auto imported, we can uncomment these lines.
Even if we do want to do this, it would probably be better to have a separate discussion on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spderman3333 either revert, or address in a separate PR. Generally, you want to avoid bundling unrelated changes in the same PR (this here being some random config change that has nothing to do with the PR Title, which is all about fixing some logical error in the motor drive impl).