Move FakePIDMotor from :lib to :testing - #63
Merged
Conversation
Contributor
|
Looks good to me. Earlier I was having circular dependency issues earlier when I tried to move FakePIDMotor to testing but it looks like it's good to go |
atlanticbomber
approved these changes
Sep 26, 2025
This reduces the number of dependencies pulled in by :lib, which reduces how much code has to be deployed to the robot.
kcooney
force-pushed
the
kcooney/move-fake-pid-motor
branch
from
October 3, 2025 03:13
8d1b8b5 to
53f35e3
Compare
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Oct 4, 2025
This includes the following: - Prospect-Robotics/lib2813#62 - Prospect-Robotics/lib2813#63 - Prospect-Robotics/lib2813#65
spderman3333
pushed a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Oct 9, 2025
* Attempted to migrate references and tests to lib2813. still facing issues with accessing FakePIDMotor * Changed all tests to reference classes in lib2813. removed ParameterizedIntakeSubsystem.java, FakePIDMotor.java and ParameterizedIntakeSubsystemTest.java since they now live in lib2813. also updated lib2813 to refer to a version with those classes * Update the commit of lib2813 This includes the following: - Prospect-Robotics/lib2813#62 - Prospect-Robotics/lib2813#63 - Prospect-Robotics/lib2813#65 --------- Co-authored-by: Kevin Cooney <kcooney@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the number of dependencies pulled in by :lib, which reduces how
much code has to be deployed to the robot.