Param intake - #61
Merged
Merged
Conversation
… to this repository so we can use it in future bots. Currently does not compile
…IDMotor is now in the main library to allow for access from both lib tests and robot tests. :lib now depends on google truth library for implementation as well as testing
spderman3333
left a comment
spderman3333
left a comment
Member
There was a problem hiding this comment.
Have you confirmed auto builder works?
kcooney
reviewed
Sep 25, 2025
| testRuntimeOnly('org.junit.vintage:junit-vintage-engine') | ||
| testImplementation 'junit:junit:4.13.2' | ||
| testImplementation 'com.google.truth:truth:1.4.4' | ||
| implementation 'com.google.truth:truth:1.4.4'//needed for FakePIDMotor |
Contributor
There was a problem hiding this comment.
Having :lib2813:lib depend on Truth would add a lot of classes to the code deployed to the robot. We should avoid that if possible.
I think it would be best to move FakePIDMotor to :lib2813:testing`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ParameterizedIntakeSubsystem and FakePIDMotor classes to lib2813 (originally in robot2025) so we can use them in future projects. Also moved appropriate tests over.