Store PersistedConfiguration record registry outside of /Preferences - #58
Merged
Conversation
kcooney
force-pushed
the
kcooney/persisted-configuration-registry
branch
3 times, most recently
from
September 17, 2025 23:52
570f78e to
61f8bfe
Compare
This change moves the NetworkTables keys which store which PersistedConfiguration names map to which record classes outside of /Preferences. As of the 2025 WPILib code, Preferences has a listener that updates all new topics to be persistent (for backwards compatibility of old dashboards; see wpilibsuite/allwpilib@87fc49c66). Due to this, we cannot store data that should not be persistent under /Preferences without risking a race condition where the topic is later marked as persistent.
kcooney
force-pushed
the
kcooney/persisted-configuration-registry
branch
from
September 20, 2025 00:13
61f8bfe to
031d444
Compare
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Sep 24, 2025
This includes the following: - Prospect-Robotics/lib2813#54 - Prospect-Robotics/lib2813#55 - Prospect-Robotics/lib2813#56 - Prospect-Robotics/lib2813#58 - Prospect-Robotics/lib2813#60
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Sep 24, 2025
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Sep 24, 2025
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Sep 25, 2025
This includes the following: - Prospect-Robotics/lib2813#54 - Prospect-Robotics/lib2813#55 - Prospect-Robotics/lib2813#56 - Prospect-Robotics/lib2813#58 - Prospect-Robotics/lib2813#59 - Prospect-Robotics/lib2813#60 Local changes: - Remove now-redundant overrides of `MotorSubsystem.getAppliedCurrent()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves the NetworkTables keys which store which PersistedConfiguration names map to which record classes outside of /Preferences.
As of the 2025 WPILib code, Preferences has a listener that updates all new topics to be persistent (for backwards compatibility of old dashboards; see wpilibsuite/allwpilib@87fc49c66). Due to this, we cannot store data that should not be persistent under /Preferences without risking a race condition where the topic is later marked as persistent.