Skip to content

Call NetworkTableInstance.waitForListenerQueue() before close() #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcooney merged 2 commits into from
Sep 23, 2025
Merged

Call NetworkTableInstance.waitForListenerQueue() before close() #54

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d34519d
Call NetworkTableInstance.waitForListenerQueue() before close()
kcooney Sep 6, 2025
b13cc4c
Call NetworkTableInstance.startLocal()
kcooney Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions lib/src/test/java/com/team2813/lib2813/preferences/IsolatedPreferences.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,13 @@
import edu.wpi.first.networktables.NetworkTable;
import edu.wpi.first.networktables.NetworkTableInstance;
import edu.wpi.first.wpilibj.Preferences;
import java.util.concurrent.Executors;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.TimeUnit;
import org.junit.rules.ExternalResource;

/**
* A JUnit rule that ensures that changes to preferences done by a test are not leaked out to other
* tests.
*/
public final class IsolatedPreferences extends ExternalResource {
private static final ScheduledExecutorService CLOSE_EXECUTOR =
Executors.newSingleThreadScheduledExecutor();
private NetworkTableInstance tempInstance;

/** Gets the {@link NetworkTable} that contains the preference values. */
Expand All @@ -26,12 +21,18 @@ public NetworkTable getPreferencesTable() {
protected void before() {
NetworkTableInstance.getDefault();
tempInstance = NetworkTableInstance.create();
tempInstance.startLocal();
Preferences.setNetworkTableInstance(tempInstance);
}

@Override
protected void after() {
if (!tempInstance.waitForListenerQueue(.1)) {
System.err.println(
"Timed out waiting for the NetworkTableInstance listener queue to empty (waited 100ms);"
+ " JVM may crash");
}
Preferences.setNetworkTableInstance(NetworkTableInstance.getDefault());
CLOSE_EXECUTOR.schedule(() -> tempInstance.close(), 10, TimeUnit.MILLISECONDS);
tempInstance.close();
}
}
Loading