Update WPILibExtension to fail test if HAL.initialize() returns false - #50
Merged
Conversation
kcooney
force-pushed
the
kcooney/check-hal-initilaize-retval
branch
18 times, most recently
from
August 30, 2025 01:06
a2e0e29 to
3633de3
Compare
kcooney
force-pushed
the
kcooney/check-hal-initilaize-retval
branch
from
August 30, 2025 01:10
3633de3 to
b32a738
Compare
cuttestkittensrule
approved these changes
Sep 6, 2025
cuttestkittensrule
left a comment
cuttestkittensrule
left a comment
Collaborator
There was a problem hiding this comment.
lgtm. Pretty interesting how you made all the tests in SampleTest run under one test overall.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added tests for WPILibExtension.