Hacks to avoid SIGSEGV in tests that call Preferences.setNetworkTableInstance() - #129
Merged
Conversation
kcooney
force-pushed
the
kcooney/hack-to-avoid-sigsegv
branch
from
February 9, 2026 03:49
7d49726 to
08c9b5a
Compare
cuttestkittensrule
approved these changes
Feb 9, 2026
cuttestkittensrule
left a comment
cuttestkittensrule
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, though the javadoc should probably use @link. I will re-run the checks a few times though to see if it runs into a SISEGV, just to see if this fixes the issue for now (either way this probably reduces the chances so the change is good).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the following changes:
Listenerinstalled byPreferences.setNetworkTableInstance()NetworkTableInstanceif the queue cannot beflushed
NetworkTableInstance.startLocal()