Add annotations for JUnit Jupiter extensions - #128
Merged
Conversation
kcooney
force-pushed
the
kcooney/junit-extension-annotations
branch
11 times, most recently
from
February 9, 2026 17:27
48c8171 to
f3e241b
Compare
cuttestkittensrule
approved these changes
Feb 9, 2026
cuttestkittensrule
left a comment
cuttestkittensrule
left a comment
Collaborator
There was a problem hiding this comment.
lgtm. I have some minor comments on the documentation and the InitWPILibExtensionTest, but after those are resolved, this is ready to go.
This allows us to add optional parameters that can be specified by users of the annotations. Notably, IsolatedNetworkTables allows the user to specify waitForListenerQueueSeconds.
kcooney
force-pushed
the
kcooney/junit-extension-annotations
branch
from
February 10, 2026 03:00
f3e241b to
7e0a4e1
Compare
kcooney
force-pushed
the
kcooney/junit-extension-annotations
branch
from
February 10, 2026 03:05
7e0a4e1 to
fc3a3c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to add optional parameters that can be specified by users of the annotations.
@ProvideUniqueNetworkTableInstance- Replacement for@ExtendWith(IsolatedNetworkTablesExtension.class)Preferencesnetwork table is updated@InitWPILib- Replacement for@ExtendWith(WPILibExtension.class)