Skip to content

Lightshow cleanups - #118

Merged
cuttestkittensrule merged 7 commits into
mainfrom
kcooney/cleanups
Feb 1, 2026
Merged

Lightshow cleanups#118
cuttestkittensrule merged 7 commits into
mainfrom
kcooney/cleanups

Conversation

@kcooney

@kcooney kcooney commented Jan 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Make fields final that can be final
  • Set an initial value for defaultState
  • Rename State.apply() to isActive()
  • Add comments and improve JavaDoc
  • Minor rewrites of QueueLightshow.update() (for clarity)

@kcooney
kcooney marked this pull request as ready for review January 17, 2026 19:20
@kcooney
kcooney force-pushed the kcooney/cleanups branch 4 times, most recently from 8f1ed0f to c169f38 Compare January 18, 2026 02:19
@kcooney
kcooney force-pushed the kcooney/cleanups branch 2 times, most recently from 637c016 to a2d8c81 Compare February 1, 2026 03:30
cuttestkittensrule
cuttestkittensrule approved these changes Feb 1, 2026
View reviewed changes

@cuttestkittensrule cuttestkittensrule left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :3

@kcooney
kcooney force-pushed the kcooney/cleanups branch 2 times, most recently from c3c87fd to fe176eb Compare February 1, 2026 03:42
@cuttestkittensrule
cuttestkittensrule merged commit a3bbbee into main Feb 1, 2026
1 of 3 checks passed
@cuttestkittensrule
cuttestkittensrule deleted the kcooney/cleanups branch February 1, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cuttestkittensrule cuttestkittensrule cuttestkittensrule approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Version 2.0.0 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@kcooney @cuttestkittensrule